Merge lp://staging/~paride/auto-upgrade-testing-specifications/set-debian-frontend into lp://staging/auto-upgrade-testing-specifications

Proposed by Paride Legovini
Status: Merged
Approved by: Brian Murray
Approved revision: 64
Merged at revision: 64
Proposed branch: lp://staging/~paride/auto-upgrade-testing-specifications/set-debian-frontend
Merge into: lp://staging/auto-upgrade-testing-specifications
Diff against target: 363 lines (+28/-28)
28 files modified
profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-impish-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-impish-kubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-impish-lubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-impish-ubuntu-mate-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-impish-xubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-hirsute-impish-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-hirsute-impish-kubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-hirsute-impish-lubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-hirsute-impish-ubuntu-mate-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-hirsute-impish-xubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-impish-jammy-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-impish-jammy-kubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-impish-jammy-lubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-impish-jammy-ubuntu-mate-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-impish-jammy-xubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-jammy-kinetic-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-jammy-kinetic-kubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-jammy-kinetic-lubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-jammy-kinetic-ubuntu-mate-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-jammy-kinetic-xubuntu-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-xenial-bionic-desktop-amd64_qemu.yaml (+1/-1)
profiles/ubuntu-xenial-bionic-desktop-i386_qemu.yaml (+1/-1)
To merge this branch: bzr merge lp://staging/~paride/auto-upgrade-testing-specifications/set-debian-frontend
Reviewer Review Type Date Requested Status
Brian Murray (community) Approve
Review via email: mp+425732@code.staging.launchpad.net

Commit message

Set DEBIAN_FRONTEND when installing the metapackages

The specific reason why we're adding this now is a debconf message with
"error" priority which is printed at install time by a package (encfs)
which is brought in as indirect dependency of several flavor metapackages.

Note that normally the installation is done from ISO images, and therefore
the message is handled by the installer. In other words DEBIAN_FRONTEND is
set in a testbed setup stage users are normally not exposed to.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I'm confused by your latest sentence in the commit message:

"We're not setting DEBIAN_FRONTEND=noninteractive during the upgrade
process, which ideally we don't want to be blocked by debconf."

If we did not want the upgrade process blocked wouldn't we set the frontend to 'noninteractive'. We do want the upgrade to stop if there are debconf prompts so that is why it isn't set. Or am I misunderstanding?

Revision history for this message
Paride Legovini (paride) wrote :

I meant: we don't want the upgrade process to stop _even outside automation_, so we don't need to set DEBIAN_FRONTEND=noninteractive, and actually we don't want to set it, because we want to spot new blocking questions.

I can see that's confusing, I can reword it tomorrow.

Revision history for this message
Paride Legovini (paride) wrote :

@Brian I amended the commit message. I'm not mentioning the upgrade process anymore as that part of the commit message was imprecise: the Debian frontend is handled by auto-upgrade-testing via

 do-release-upgrade -f <frontend>

and apparently auto-upgrade-testing sets it to noninteractive (DistUpgradeViewNonInteractive). We can evaluate changing this in the future to spot blocking debconf questions, but for the moment this is how it is.

63. By Paride Legovini

Set DEBIAN_FRONTEND when installing the metapackages

The specific reason why we're adding this now is a debconf message with
"error" priority which is printed at install time by a package (encfs)
which is brought in as indirect dependency of several flavor metapackages.

Note that normally the installation is done from ISO images, and therefore
the message is handled by the installer. In other words DEBIAN_FRONTEND is
set in a testbed setup stage users are normally not exposed to.

64. By Paride Legovini

Make unifor use of `apt-get -y` across the profiles

Revision history for this message
Paride Legovini (paride) wrote :

Added another minor change: always call apt-get with a single `-y` flag.

Revision history for this message
Brian Murray (brian-murray) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches