Merge lp://staging/~paolorotolo/ubuntu-clock-app/fix-for-1291502 into lp://staging/ubuntu-clock-app/saucy
Proposed by
Paolo Rotolo
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Nekhelesh Ramananthan | ||||
Proposed branch: | lp://staging/~paolorotolo/ubuntu-clock-app/fix-for-1291502 | ||||
Merge into: | lp://staging/ubuntu-clock-app/saucy | ||||
To merge this branch: | bzr merge lp://staging/~paolorotolo/ubuntu-clock-app/fix-for-1291502 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nekhelesh Ramananthan | Needs Fixing | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Pending | |
Review via email: mp+211405@code.staging.launchpad.net |
Commit message
- Stopwatch: Lap list now disappears automatically when empty;
- Stopwatch: Added new animation of text label;
Fixes LP: #1291502.
Description of the change
- Stopwatch: Lap list now disappears automatically when empty;
- Stopwatch: Added new animation of text label;
Fixes LP: #1291502.
To post a comment you must log in.
Unmerged revisions
- 378. By Paolo Rotolo
-
Fixed some issue with animation.
- 377. By Paolo Rotolo
-
- Stopwatch: Lap list now disappears automatically when empty.
- Stopwatch: Added new animation of text label.Fixes LP: #1291502.
Hey Paolo, thnx for working on this. For some reason launchpad is not showing me the code diff, so in case you are unable to find some of the things in my review, feel free to ask me.
I believe Lucas's design solution for this bug can be found at https:/ /launchpadlibra rian.net/ 169527292/ Captura% 20de%20pantalla %20de%202014- 03-14%2017% 3A11%3A17. png.
I noticed that you hide the Recorded Laps header when the laps count is 0. However if you look at lucas's design you will notice that it is supposed to slide in from the bottom to let the user know that something is present in the bottom. Can you fix this pls.