Ubuntu
pulseaudio package

Merge lp://staging/~pali/ubuntu/precise/pulseaudio/pulseaudio into lp://staging/ubuntu/precise/pulseaudio

  1. Precise (12.04)
  2. pulseaudio
  3. Merge into precise
Proposed by Pali
Status: Rejected
Rejected by: Stéphane Graber
Proposed branch: lp://staging/~pali/ubuntu/precise/pulseaudio/pulseaudio
Merge into: lp://staging/ubuntu/precise/pulseaudio
Diff against target: 140 lines (+40/-83)
3 files modified
debian/pulseaudio.default (+2/-0)
debian/pulseaudio.init (+0/-83)
debian/pulseaudio.upstart (+38/-0)
To merge this branch: bzr merge lp://staging/~pali/ubuntu/precise/pulseaudio/pulseaudio
Reviewer Review Type Date Requested Status
Serge Hallyn Needs Resubmitting
Ubuntu branches Pending
Review via email: mp+92622@code.staging.launchpad.net

Description of the change

* Convert System V pulseaudio init script to upstart and added support for additional pulseaudio command line arguments

This merge request supersed old request:
https://code.launchpad.net/~pali/ubuntu/oneiric/pulseaudio/pulseaudio/+merge/67286

To post a comment you must log in.
lp://staging/~pali/ubuntu/precise/pulseaudio/pulseaudio updated
165. By Pali

Convert System V pulseaudio init script to upstart

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks for this merge proposal. The only comment I have is that you
removed debian/pulseaudio.init, which isn't necessary. Ordinarely I'd
say it adds extra delta over the debian package, but since we're
currently not tracking the debian package anyway, it probably doesn't
matter.

I don't have the upload rights to this package, but I hope someone
consider that I've reviewed and approved

review: Approve
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

I'm sorry, I wasn't looking right. Since this is against the packaging tree,
it should have an accompanying changelog entry. I have created a new merge
request at

lp:~serge-hallyn/ubuntu/precise/pulseaudio/pa-upstart

with a changelog entry credited to you. If you prefer to make the changes
yourself and resubmit, please go ahead.

Please note that as this is not addressing any particular bug, it is probably
too late in the Precise cycle to accept a patch such as this.

review: Needs Resubmitting
Revision history for this message
Stéphane Graber (stgraber) wrote :

I'm marking this one as rejected as we now have a duplicate in the queue (Hallyn's).

I don't think we should do the change for Precise but I'll let a desktop team reviewer make the decision and if they feel like we should have it, then ask for a freeze exception.

Unmerged revisions

165. By Pali

Convert System V pulseaudio init script to upstart

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: