Merge lp://staging/~pali/ubuntu/oneiric/pulseaudio/pulseaudio into lp://staging/ubuntu/oneiric/pulseaudio
Proposed by
Pali
Status: | Work in progress |
---|---|
Proposed branch: | lp://staging/~pali/ubuntu/oneiric/pulseaudio/pulseaudio |
Merge into: | lp://staging/ubuntu/oneiric/pulseaudio |
Diff against target: |
162 lines (+43/-83) 5 files modified
debian/pulseaudio.default (+2/-0) debian/pulseaudio.init (+0/-83) debian/pulseaudio.install (+1/-0) debian/pulseaudio.upstart (+38/-0) debian/rules (+2/-0) |
To merge this branch: | bzr merge lp://staging/~pali/ubuntu/oneiric/pulseaudio/pulseaudio |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pali (community) | Needs Resubmitting | ||
Scott Moser | Needs Fixing | ||
Ubuntu branches | Pending | ||
Review via email: mp+67286@code.staging.launchpad.net |
Description of the change
* Convert System V pulseaudio init script to upstart
* Added support for additional pulseaudio command line arguments in upstart
To post a comment you must log in.
I built your branch, but it failed to install. The issue was the way you are 'stop'ing in the upstart script.
exiting in a 'script' section will cause upstart to try to respawn the job. Eventually that will hit the respawn limit.
So, the changes I suggest are: pulseaudio. install as dh_installinit will do that for you. /debian/ tmp/etc/ init /debian/ pulseaudio. upstart $(CURDIR) /debian/ tmp/etc/ init/pulseaudio .conf pulseaudio. init pulseaudio. init
* fix the issue of 'start' with a pre-start script (you can see a similar example in the libvirt-bin package).
* you should also probably do the 'mkdir -p /var/run/pulse' in pre-start.
* Also, if you use dh_installinit, you can actually leave the old .init file around, and do not have to modify debian/
- mkdir -p $(CURDIR)
- cp -a $(CURDIR)
+ dh_installinit
* re-add the pulseaudio.init
bzr revert -r 143 debian/
bzr add debian/