Merge lp://staging/~pali/ubuntu/oneiric/pulseaudio/pulseaudio into lp://staging/ubuntu/oneiric/pulseaudio

Proposed by Pali
Status: Work in progress
Proposed branch: lp://staging/~pali/ubuntu/oneiric/pulseaudio/pulseaudio
Merge into: lp://staging/ubuntu/oneiric/pulseaudio
Diff against target: 162 lines (+43/-83)
5 files modified
debian/pulseaudio.default (+2/-0)
debian/pulseaudio.init (+0/-83)
debian/pulseaudio.install (+1/-0)
debian/pulseaudio.upstart (+38/-0)
debian/rules (+2/-0)
To merge this branch: bzr merge lp://staging/~pali/ubuntu/oneiric/pulseaudio/pulseaudio
Reviewer Review Type Date Requested Status
Pali (community) Needs Resubmitting
Scott Moser Needs Fixing
Ubuntu branches Pending
Review via email: mp+67286@code.staging.launchpad.net

Description of the change

* Convert System V pulseaudio init script to upstart
* Added support for additional pulseaudio command line arguments in upstart

To post a comment you must log in.
Revision history for this message
Scott Moser (smoser) wrote :

I built your branch, but it failed to install. The issue was the way you are 'stop'ing in the upstart script.
exiting in a 'script' section will cause upstart to try to respawn the job. Eventually that will hit the respawn limit.

So, the changes I suggest are:
 * fix the issue of 'start' with a pre-start script (you can see a similar example in the libvirt-bin package).
 * you should also probably do the 'mkdir -p /var/run/pulse' in pre-start.
 * Also, if you use dh_installinit, you can actually leave the old .init file around, and do not have to modify debian/pulseaudio.install as dh_installinit will do that for you.
   - mkdir -p $(CURDIR)/debian/tmp/etc/init
   - cp -a $(CURDIR)/debian/pulseaudio.upstart $(CURDIR)/debian/tmp/etc/init/pulseaudio.conf
   + dh_installinit
 * re-add the pulseaudio.init
   bzr revert -r 143 debian/pulseaudio.init
   bzr add debian/pulseaudio.init

review: Needs Fixing
Revision history for this message
Chris Halse Rogers (raof) wrote :

I'm marking this as “In Progress” to drop it off the sponsorship queue.

Once you've addressed the review above, please set the status back to “Needs Review” and it will go back onto the sponsorship queue.

Revision history for this message
Pali (pali) wrote :

Here is new merge request:
https://code.launchpad.net/~pali/ubuntu/precise/pulseaudio/pulseaudio/+merge/92622

I tried to "resubmit proposal" button, but launchpad does not worked.

review: Needs Resubmitting
Revision history for this message
Evan Broder (broder) wrote :

Pali - currently both merge proposals are marked as "Needs Review", which causes them both to show up on the sponsorship queue. Could you please change this one back to "Work In Progress"?

(I would do it, but am blocked by bug #612391)

Revision history for this message
Pali (pali) wrote :

changed back to work in progress. maybe this merge request could be closed or marked as superseded (but I do not know how).

Unmerged revisions

145. By Pali

Added support for additional pulseaudio command line arguments in upstart

144. By Pali

Convert System V pulseaudio init script to upstart

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: