Merge ~paelzer/ubuntu/+source/spice:merge-14.2-4-focal into ubuntu/+source/spice:debian/sid

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: bc1fce0cf6c5e4393cf75f335975e75be1050898
Merge reported by: Bryce Harrington
Merged at revision: bc1fce0cf6c5e4393cf75f335975e75be1050898
Proposed branch: ~paelzer/ubuntu/+source/spice:merge-14.2-4-focal
Merge into: ubuntu/+source/spice:debian/sid
Diff against target: 234 lines (+151/-7)
6 files modified
debian/changelog (+113/-0)
debian/control (+2/-2)
debian/source/include-binaries (+1/-0)
debian/tests/automated-tests (+8/-4)
debian/tests/control (+2/-1)
debian/tests/regression-test.py (+25/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Canonical Server packageset reviewers Pending
Canonical Server Pending
Review via email: mp+375496@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Bileto ticket: https://bileto.ubuntu.com/#/ticket/3837
PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3837

Pushed tags to ease review:
To ssh://git.launchpad.net/~paelzer/ubuntu/+source/spice
 * [new tag] lp1852439/logical/0.14.2-0ubuntu2 -> lp1852439/logical/0.14.2-0ubuntu2
 * [new tag] lp1852439/new/debian -> lp1852439/new/debian
 * [new tag] lp1852439/old/debian -> lp1852439/old/debian
 * [new tag] lp1852439/old/ubuntu -> lp1852439/old/ubuntu
 * [new tag] lp1852439/reconstruct/0.14.2-0ubuntu2 -> lp1852439/reconstruct/0.14.2-0ubuntu2
 * [new tag] lp1852439/split/0.14.2-0ubuntu2 -> lp1852439/split/0.14.2-0ubuntu2

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

As a summary, Debian took all we had except the autopkgtest fixes.

Plan (for now): I'll rebase and test those in Focal, once they work I'll open an MP with Debian (they are now on salsa, but were not in the past)

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Well it is time to revisit the autopkgtest for real.
It is sort of broken as the Debian history shows [1]
I can fix it up to somewhat work.
But also upstream has sort of given up/neglected it [2]

I have submitted my fixes to Debian [3], but if they ack to drop these tests completely I'd want to follow on that.

Note on [4] that amd64 & arm64 are the only arches this worked before, so this isn't a regression.

[1]: https://ci.debian.net/packages/s/spice/
[2]: https://gitlab.freedesktop.org/spice/spice/issues/34
[3]: https://salsa.debian.org/debian/spice/merge_requests/1
[4]: https://bileto.ubuntu.com/excuses/3837/focal.html

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Marking MP ready for review

Revision history for this message
Bryce Harrington (bryce) wrote :

I've run the autopkgtests on the ppa package in lxc, and looked at the failing test-display-streaming test - for me it doesn't even produce output, I guess because there's no $DISPLAY available? The bileto test results log also shows the test failed, although it shows up as a PASS in the excuses results(?!?) Guessing there's some setup work needed to get the remote display registered properly in lxc? (Might be useful for future reviewing to have a paint-by-numbers set of commands to run to get remote display enabled inside an lxc container.)

However, given that test-display-streaming appears to not have been hooked up before, and may not be getting necessary attention upstream, it may make sense to disable it. It looks like this would avoid needing to build some C code, which would also make test run time faster. Given that upstream appears to have an active and well-maintained CI system, the risk of something being missed by excluding this test seems minimal.

That said, given that the purpose of this tool is for accessing a remote desktop, some sort of smoke test to verify graphics are getting generated and transmitted from server to client would be appropriate for acceptance testing. But that seems a different scope than this merge from debian.

Anyway, everything else in the merge LGTM; things I've checked listed below. As to the failed test, while I lean towards disabling it, I don't feel strongly enough on that point to block landing the merge, esp. since it isn't showing up as a fail on the excuses page.

- [√] changelog entry correct, targeted to correct codename
- [√] no major upstream changes to consider
- [√] debian changes look safe
- [√] update-maintainer has been run
- [√] changes forwarded upstream/debian (if appropriate)
- [√] nothing else to drop
- [-] patches match what was proposed upstream
- [-] patches correctly included in debian/patches/series?
- [-] patches have correct DEP3 metadata

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks for the review, yeah we are in sync of dropping the test - I just want to do that "with Debian" hence the MR up there.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/spice
 * [new tag] upload/0.14.2-4ubuntu1 -> upload/0.14.2-4ubuntu1

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading spice_0.14.2-4ubuntu1.dsc: done.
  Uploading spice_0.14.2.orig.tar.bz2: done.
  Uploading spice_0.14.2-4ubuntu1.debian.tar.xz: done.
  Uploading spice_0.14.2-4ubuntu1_source.buildinfo: done.
  Uploading spice_0.14.2-4ubuntu1_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Bryce Harrington (bryce) wrote :

This has migrated into focal

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches