Account - Financial Tools

Merge lp://staging/~ovnicraft/account-financial-tools/account-financial-tools-inv-voucher-constraints into lp://staging/~account-core-editors/account-financial-tools/7.0

account-financial-tools-inv-voucher-constraints
Merge into 7.0

Proposed by Cristian Salamea on 2013-07-17

Status:	Work in progress
Proposed branch:	lp://staging/~ovnicraft/account-financial-tools/account-financial-tools-inv-voucher-constraints
Merge into:	lp://staging/~account-core-editors/account-financial-tools/7.0
Diff against target:	123 lines (+107/-0) (has conflicts) 3 files modified account_constraints/__init__.py (+23/-0) account_constraints/__openerp__.py (+41/-0) account_constraints/voucher.py (+43/-0) Conflict adding file account_constraints. Moved existing file to account_constraints.moved.
To merge this branch:	bzr merge lp://staging/~ovnicraft/account-financial-tools/account-financial-tools-inv-voucher-constraints
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Maxime Chambreuil (http://www.savoirfairelinux.com)	code review		Needs Fixing on 2013-11-03
Nhomar - Vauxoo			Needs Information on 2013-07-19
Joël Grand-Guillaume @ camptocamp	code review, no tests		Approve on 2013-07-19
Frederic Clementi - Camptocamp		2013-07-17	Pending
Review via email: mp+175417@code.staging.launchpad.net

Description of the change

Added constraint module for account.
First constaint added in vouchers
Voucher module pass silent difference to payable|receivable account if amount_diff is > 0.

Revision history for this message

Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote on 2013-07-19:

LGTM from code point of view, accountant opinion might be useful before merging.

review: Approve (code review, no tests)

Revision history for this message

Nhomar - Vauxoo (nhomar) wrote on 2013-07-19:

Hello.

In the description:

62 + 'description': """This module implement constraints required in account documents:
63 + Voucher: check open balance with amount
64 + Invoice: due_date must be in period

And in the code there are only one contraint.

I don't understand why validate the amount here, if you please can enlight us to understand why this amount from a functional PoV must be lower than another it should be great.

From My PoV i can pay more or less than what I mark in the invoice, we just need to be sure the reconciliation stay as partial (as it is now) to use the difference in other payment process, but may be I am wrong.

Thanks for your contribution.

review: Needs Information

Revision history for this message

Cristian Salamea (ovnicraft) wrote on 2013-10-24:

Hi,

in fact i consider a bug in openerp and constraint solve this problem:
Make and invoice, click on pay all default values are loaded, user can chance amount value, error happens when you pay more, system silent resolve problem and send the difference to payable|receivable account, from account PoV this cannot happen.

Constraint make this explicit, if you will let open balance most be less or the same value, if more change balance option to send to specific account.

This make more clear the process to account users.

I work this with accountants customers and all are a little bit happy .-).

Revision history for this message

Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote on 2013-11-03:

Please update the module description according to the constraint provided, or implement the second constraint.

Thanks.

review: Needs Fixing (code review)

Revision history for this message

Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote on 2013-12-20:

No changes since 2013-11-03 after Need Fixing request -> I set this in WIP

@Cristian Salamea (Gnuthink) (ovnicraft)

Please do the required changes then set it in Needs Review again

(And please do a merge of lp:account-financial-tools in this branche to resolve conflicts)

Cheers,
Yannick

Unmerged revisions

96. By Cristian Salamea on 2013-07-16: [FIX] typo message error
95. By Cristian Salamea on 2013-01-02: [IMP] simplest method validation, dont allow users cause entry with extra line error
94. By Cristian Salamea on 2013-01-02: [IMP] constraint in voucher amount