Merge lp://staging/~ossug-hychen/gnome-settings-daemon/fix-868400-oneiric into lp://staging/ubuntu/oneiric-proposed/gnome-settings-daemon

Proposed by James M. Leddy
Status: Merged
Merge reported by: Dimitri John Ledkov
Merged at revision: not available
Proposed branch: lp://staging/~ossug-hychen/gnome-settings-daemon/fix-868400-oneiric
Merge into: lp://staging/ubuntu/oneiric-proposed/gnome-settings-daemon
Diff against target: 1419 lines (+1348/-1)
6 files modified
.pc/52_kill_syndaemon_when_gsd_die.patch/plugins/mouse/gsd-mouse-manager.c (+1229/-0)
.pc/applied-patches (+1/-0)
debian/changelog (+10/-0)
debian/patches/52_kill_syndaemon_when_gsd_die.patch (+76/-0)
debian/patches/series (+1/-0)
plugins/mouse/gsd-mouse-manager.c (+31/-1)
To merge this branch: bzr merge lp://staging/~ossug-hychen/gnome-settings-daemon/fix-868400-oneiric
Reviewer Review Type Date Requested Status
Dimitri John Ledkov (community) Approve
Marc Deslauriers Needs Fixing
Review via email: mp+117358@code.staging.launchpad.net

Description of the change

SRU from Precise that ensures that there is only ever one syndaemon process running.

To post a comment you must log in.
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

A few comments:

1- Please tag your patch using DEP-3: http://dep.debian.net/deps/dep3/
   - Add link to upstream commit: http://git.gnome.org/browse/gnome-settings-daemon/commit/?id=31aa30a0207b9de77706f03dacb8d914c959d3a6
   - Add link to upstream bug
   - Add link to ubuntu bug
   - etc.
2- Please remove "[ Hsin-Yi, Chen (hychen) ]" from debian/changelog, it's redundant
3- Please fix typo in changelog
4- Please revert modifications to older lines in the debian/changelog file

Thanks!

review: Needs Fixing
185. By Hsin-Yi, Chen (hychen)

* To remove "[ Hsin-Yi, Chen (hychen) ]" from debian/changelog, it's redundant
* To fix typo in debian/changelog
* To revert modifications to older lines in the debian/changelog file

186. By Hsin-Yi, Chen (hychen)

* To tag the patch by using DEP-3: http://dep.debian.net/deps/dep3/

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Looks good. Uploaded.
[ubuntu/oneiric-proposed] gnome-settings-daemon 3.2.2-0ubuntu2.3 (Waiting for approval)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches