Merge lp://staging/~osomon/webbrowser-app/use-oxide-1.15-apis into lp://staging/webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1475
Merged at revision: 1472
Proposed branch: lp://staging/~osomon/webbrowser-app/use-oxide-1.15-apis
Merge into: lp://staging/webbrowser-app
Diff against target: 295 lines (+126/-21)
6 files modified
debian/control (+2/-2)
src/Ubuntu/Web/UbuntuWebView02.qml (+22/-4)
src/Ubuntu/Web/UserAgent02.qml (+2/-5)
src/app/webbrowser/Browser.qml (+36/-1)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+49/-1)
tests/autopilot/webbrowser_app/tests/test_touchselection.py (+15/-8)
To merge this branch: bzr merge lp://staging/~osomon/webbrowser-app/use-oxide-1.15-apis
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+296407@code.staging.launchpad.net

Commit message

Use new oxide 1.15 APIs to fix bugs and implement new features:
 - touch selection updates
 - use the chromium version exposed by oxide in the default UA string
 - keyboard shortcuts for zoom factor

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
1475. By Olivier Tilloy

Fix existing autopilot tests for touch selection.

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1475
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/515/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/517/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/517
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/510
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial/510
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/505/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/505/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/505/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/505
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/505/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/505/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/505
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/505/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/515/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: