webbrowser-app

Merge lp://staging/~osomon/webbrowser-app/sdk-generic-toolbar into lp://staging/webbrowser-app

  1. sdk-generic-toolbar
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Ugo Riboni
Approved revision: 125
Merged at revision: 124
Proposed branch: lp://staging/~osomon/webbrowser-app/sdk-generic-toolbar
Merge into: lp://staging/webbrowser-app
Diff against target: 392 lines (+71/-229)
5 files modified
src/Ubuntu/Browser/Browser.qml (+51/-48)
src/Ubuntu/Browser/Chrome.qml (+1/-1)
src/Ubuntu/Browser/RevealingBar.qml (+0/-112)
tests/autopilot/webbrowser_app/tests/__init__.py (+4/-26)
tests/autopilot/webbrowser_app/tests/test_toolbar.py (+15/-42)
To merge this branch: bzr merge lp://staging/~osomon/webbrowser-app/sdk-generic-toolbar
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+161956@code.staging.launchpad.net

Commit message

Replace the custom RevealingBar component with the Panel from the UITK.

Description of the change

Note to the reviewer: this change depends on a version of the UITK that hasn’t been released yet (trunk revision 461), so it shouldn’t be approved until the UITK gets a newer release.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:124
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/68/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-amd64-ci/30
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-armhf-ci/65
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-armhf-ci/65/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-i386-ci/65

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/68/rebuild

review: Approve (continuous-integration)
lp://staging/~osomon/webbrowser-app/sdk-generic-toolbar updated
125. By Olivier Tilloy

Merge the latest changes from trunk.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:125
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/71/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-amd64-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-armhf-ci/68
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-armhf-ci/68/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-i386-ci/68

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/71/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

Works as advertised and can't spot any issues in the code

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: