webbrowser-app

Merge lp://staging/~osomon/webbrowser-app/qmltests into lp://staging/webbrowser-app/staging

  1. qmltests
  2. Merge into staging
Proposed by Olivier Tilloy
Status: Needs review
Proposed branch: lp://staging/~osomon/webbrowser-app/qmltests
Merge into: lp://staging/webbrowser-app/staging
Diff against target: 13088 lines (+5613/-6226)
150 files modified
.bzrignore (+2/-0)
CMakeLists.txt (+1/-1)
README.md (+112/-138)
debian/control (+7/-19)
debian/rules (+1/-1)
debian/tests/control (+4/-13)
debian/tests/run-qmltests.sh (+9/-0)
debian/tests/touch-session-autopilot (+0/-40)
debian/webbrowser-app-autopilot.install (+0/-1)
src/app/BrowserWindow.qml (+2/-2)
src/app/ErrorSheet.qml (+3/-1)
src/app/GeolocationPermissionRequest.qml (+2/-1)
src/app/HttpAuthenticationDialog.qml (+1/-0)
src/app/MediaAccessDialog.qml (+3/-1)
src/app/Share.qml (+1/-0)
src/app/browserapplication.cpp (+2/-1)
src/app/config.h.in (+3/-3)
src/app/webbrowser/AddressBar.qml (+1/-0)
src/app/webbrowser/BookmarkOptions.qml (+6/-1)
src/app/webbrowser/BookmarksFoldersView.qml (+3/-2)
src/app/webbrowser/BookmarksFoldersViewWide.qml (+3/-3)
src/app/webbrowser/BookmarksView.qml (+1/-0)
src/app/webbrowser/BookmarksViewWide.qml (+1/-0)
src/app/webbrowser/Browser.qml (+9/-5)
src/app/webbrowser/BrowserPage.qml (+1/-0)
src/app/webbrowser/BrowserTab.qml (+14/-3)
src/app/webbrowser/ContextMenuMobile.qml (+2/-1)
src/app/webbrowser/ContextMenuWide.qml (+1/-0)
src/app/webbrowser/DownloadDelegate.qml (+1/-0)
src/app/webbrowser/DownloadsPage.qml (+3/-0)
src/app/webbrowser/ExpandedHistoryView.qml (+3/-1)
src/app/webbrowser/HistoryView.qml (+1/-0)
src/app/webbrowser/HistoryViewWide.qml (+2/-1)
src/app/webbrowser/HistoryViewWithExpansion.qml (+1/-0)
src/app/webbrowser/NewTabView.qml (+1/-0)
src/app/webbrowser/NewTabViewWide.qml (+1/-0)
src/app/webbrowser/SadTab.qml (+2/-0)
src/app/webbrowser/SettingsPage.qml (+8/-3)
src/app/webbrowser/TabsBar.qml (+2/-0)
src/app/webbrowser/TabsList.qml (+1/-0)
src/app/webbrowser/UrlDelegate.qml (+1/-0)
src/app/webbrowser/UrlDelegateWide.qml (+1/-0)
src/app/webbrowser/webbrowser-app.cpp (+1/-1)
src/app/webbrowser/webbrowser-app.qml (+6/-0)
src/app/webcontainer/webapp-container.qml (+3/-0)
tests/CMakeLists.txt (+1/-0)
tests/autopilot/CMakeLists.txt (+1/-1)
tests/autopilot/webbrowser_app/__init__.py (+0/-44)
tests/autopilot/webbrowser_app/emulators/__init__.py (+0/-15)
tests/autopilot/webbrowser_app/emulators/browser.py (+0/-793)
tests/autopilot/webbrowser_app/tests/__init__.py (+0/-334)
tests/autopilot/webbrowser_app/tests/http_server.py (+0/-340)
tests/autopilot/webbrowser_app/tests/test_addressbar_bookmark.py (+0/-78)
tests/autopilot/webbrowser_app/tests/test_addressbar_states.py (+0/-86)
tests/autopilot/webbrowser_app/tests/test_backforward.py (+0/-52)
tests/autopilot/webbrowser_app/tests/test_basic_authentication.py (+0/-49)
tests/autopilot/webbrowser_app/tests/test_bookmark_options.py (+0/-267)
tests/autopilot/webbrowser_app/tests/test_content_pick.py (+0/-37)
tests/autopilot/webbrowser_app/tests/test_contextmenu.py (+0/-232)
tests/autopilot/webbrowser_app/tests/test_downloads.py (+0/-129)
tests/autopilot/webbrowser_app/tests/test_errorsheet.py (+0/-59)
tests/autopilot/webbrowser_app/tests/test_findinpage.py (+0/-198)
tests/autopilot/webbrowser_app/tests/test_fullscreen.py (+0/-131)
tests/autopilot/webbrowser_app/tests/test_geolocation.py (+0/-37)
tests/autopilot/webbrowser_app/tests/test_history.py (+0/-187)
tests/autopilot/webbrowser_app/tests/test_js_dialogs.py (+0/-158)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+0/-623)
tests/autopilot/webbrowser_app/tests/test_media_access_permission.py (+0/-100)
tests/autopilot/webbrowser_app/tests/test_multiple_windows.py (+0/-262)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+0/-478)
tests/autopilot/webbrowser_app/tests/test_sad_tab.py (+0/-74)
tests/autopilot/webbrowser_app/tests/test_settings.py (+0/-199)
tests/autopilot/webbrowser_app/tests/test_site_previews.py (+0/-170)
tests/autopilot/webbrowser_app/tests/test_suggestions.py (+0/-368)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+0/-341)
tests/autopilot/webbrowser_app/tests/test_title.py (+0/-30)
tests/autopilot/webbrowser_app/tests/test_touchselection.py (+0/-110)
tests/qmltests/CMakeLists.txt (+1/-0)
tests/qmltests/httpserver.py (+174/-0)
tests/qmltests/webbrowser-app/CMakeLists.txt (+60/-0)
tests/qmltests/webbrowser-app/SingleWindowTestCase.qml (+164/-0)
tests/qmltests/webbrowser-app/WebbrowserAppTestCase.qml (+138/-0)
tests/qmltests/webbrowser-app/basicauth.py (+36/-0)
tests/qmltests/webbrowser-app/blanktargetlink.html (+7/-0)
tests/qmltests/webbrowser-app/changingfavicon.html (+15/-0)
tests/qmltests/webbrowser-app/changingtitle.html (+17/-0)
tests/qmltests/webbrowser-app/closeself.html (+7/-0)
tests/qmltests/webbrowser-app/downloadpdfgenericmime.py (+5/-0)
tests/qmltests/webbrowser-app/favicon.html (+8/-0)
tests/qmltests/webbrowser-app/findinpage.html (+5/-0)
tests/qmltests/webbrowser-app/fulliframewithblanktargetlink.html (+5/-0)
tests/qmltests/webbrowser-app/fullscreen.html (+19/-0)
tests/qmltests/webbrowser-app/geolocation.html (+7/-0)
tests/qmltests/webbrowser-app/image.html (+5/-0)
tests/qmltests/webbrowser-app/imagelink.html (+7/-0)
tests/qmltests/webbrowser-app/js-alert-dialog.html (+7/-0)
tests/qmltests/webbrowser-app/js-before-unload-dialog.html (+11/-0)
tests/qmltests/webbrowser-app/js-confirm-dialog.html (+13/-0)
tests/qmltests/webbrowser-app/js-prompt-dialog.html (+14/-0)
tests/qmltests/webbrowser-app/link.html (+7/-0)
tests/qmltests/webbrowser-app/media-allowed.html (+5/-0)
tests/qmltests/webbrowser-app/media-denied.html (+5/-0)
tests/qmltests/webbrowser-app/mediarequest.py (+25/-0)
tests/qmltests/webbrowser-app/newtabviewcontents-config.conf (+2/-0)
tests/qmltests/webbrowser-app/notanimage.xxx (+1/-0)
tests/qmltests/webbrowser-app/pushstate.html (+17/-0)
tests/qmltests/webbrowser-app/redirect-destination.html (+5/-0)
tests/qmltests/webbrowser-app/redirect-no-title-header.py (+4/-0)
tests/qmltests/webbrowser-app/redirect-no-title-js.html (+7/-0)
tests/qmltests/webbrowser-app/sitepreviews-config.conf (+2/-0)
tests/qmltests/webbrowser-app/suggest.py (+23/-0)
tests/qmltests/webbrowser-app/suggestions-config.conf (+2/-0)
tests/qmltests/webbrowser-app/super.html (+7/-0)
tests/qmltests/webbrowser-app/test1.html (+8/-0)
tests/qmltests/webbrowser-app/test2.html (+8/-0)
tests/qmltests/webbrowser-app/testconfig.h.in (+30/-0)
tests/qmltests/webbrowser-app/testserver.py (+32/-0)
tests/qmltests/webbrowser-app/textarea.html (+5/-0)
tests/qmltests/webbrowser-app/tst_AddressbarBookmark.qml (+58/-0)
tests/qmltests/webbrowser-app/tst_AddressbarStates.qml (+89/-0)
tests/qmltests/webbrowser-app/tst_BackForward.qml (+40/-0)
tests/qmltests/webbrowser-app/tst_BasicAuthentication.qml (+65/-0)
tests/qmltests/webbrowser-app/tst_BookmarkOptions.qml (+264/-0)
tests/qmltests/webbrowser-app/tst_ContentPicker.qml (+30/-0)
tests/qmltests/webbrowser-app/tst_ContextMenu.qml (+221/-0)
tests/qmltests/webbrowser-app/tst_Downloads.qml (+139/-0)
tests/qmltests/webbrowser-app/tst_ErrorSheet.qml (+65/-0)
tests/qmltests/webbrowser-app/tst_FindInPage.qml (+181/-0)
tests/qmltests/webbrowser-app/tst_Fullscreen.qml (+116/-0)
tests/qmltests/webbrowser-app/tst_Geolocation.qml (+40/-0)
tests/qmltests/webbrowser-app/tst_History.qml (+203/-0)
tests/qmltests/webbrowser-app/tst_JSDialogs.qml (+101/-0)
tests/qmltests/webbrowser-app/tst_Keyboard.qml (+595/-0)
tests/qmltests/webbrowser-app/tst_MediaAccess.qml (+98/-0)
tests/qmltests/webbrowser-app/tst_MultipleWindows.qml (+264/-0)
tests/qmltests/webbrowser-app/tst_NewTabViewContents.qml (+380/-0)
tests/qmltests/webbrowser-app/tst_NewTabViewLifetime.qml (+92/-0)
tests/qmltests/webbrowser-app/tst_SadTab.qml (+81/-0)
tests/qmltests/webbrowser-app/tst_Settings.qml (+192/-0)
tests/qmltests/webbrowser-app/tst_SitePreviews1.qml (+92/-0)
tests/qmltests/webbrowser-app/tst_SitePreviews2.qml (+86/-0)
tests/qmltests/webbrowser-app/tst_Suggestions.qml (+273/-0)
tests/qmltests/webbrowser-app/tst_Tabs.qml (+93/-0)
tests/qmltests/webbrowser-app/tst_TabsView.qml (+142/-0)
tests/qmltests/webbrowser-app/tst_Title.qml (+30/-0)
tests/qmltests/webbrowser-app/tst_TouchSelection.qml (+87/-0)
tests/qmltests/webbrowser-app/uploadform.html (+12/-0)
tests/qmltests/webbrowser-app/wait.py (+14/-0)
tests/qmltests/webbrowser-app/webbrowser-app-qmltests-launcher.cpp (+315/-0)
tests/unittests/qml/CMakeLists.txt (+0/-1)
To merge this branch: bzr merge lp://staging/~osomon/webbrowser-app/qmltests
Reviewer Review Type Date Requested Status
Ken VanDine packaging Approve
Review via email: mp+321844@code.staging.launchpad.net

Commit message

Convert all webbrowser-app autopilot tests to QML UI tests.

To post a comment you must log in.
lp://staging/~osomon/webbrowser-app/qmltests updated
1670. By Olivier Tilloy

Add info to README.md on how to run all test functions in one given test case.

1671. By Olivier Tilloy

Explicit definition of keyboard shortcuts for find previous/next, so that they are not DE-dependent (and so that the tests pass when run in xvfb).

1672. By Olivier Tilloy

Ensure that suggestions are rendered before clicking them.

1673. By Olivier Tilloy

Merge the latest changes from staging.

1674. By Florian Boucault

More reliable SingleWindowTestCase::browse_to().

1675. By Olivier Tilloy

Make suggestions tests more robust.

1676. By Olivier Tilloy

Declare that webbrowser-app breaks and replaces webbrowser-app-autopilot, to (hopefully) ensure it’s removed where it was previously installed.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Packaging changes look good

review: Approve (packaging)
Reply
lp://staging/~osomon/webbrowser-app/qmltests updated
1677. By Olivier Tilloy

Do not always wait for rendering of suggestions, if clicking them is not needed.

1678. By Olivier Tilloy

Merge the latest changes from staging.

1679. By Olivier Tilloy

Updated README.md to instruct how to run all the tests (unit+UI).

1680. By Olivier Tilloy

Make tests more robust.

1681. By Olivier Tilloy

Make tests that interact with the "See More" button in the narrow new tab view more robust.

1682. By Olivier Tilloy

Ensure that the suggestions are hidden before considering the load complete, so that tests that expect to interact with the webview (by e.g. clicking in the middle of it) are more robust.

1683. By Olivier Tilloy

Do not rely on clicking to change the current section.

1684. By Olivier Tilloy

Make one test more robust.

Revision history for this message
flohack (flori-bin) wrote :

UBports is interested in merging this. But it seems that part of it was already merged long time ago into trunk, so how is the branch relationship here between this MR, trunk and staging? Thx

BR

Reply
Revision history for this message
Olivier Tilloy (osomon) wrote :

@flohack: the work in this branch was never merged into trunk. What's confusing is that a couple of years ago a branch by the same name was registered on launchpad and merged into trunk. I should have deleted it before re-using the name.

Merging into staging and then back into trunk should be fine.

Reply

Unmerged revisions

1684. By Olivier Tilloy

Make one test more robust.

1683. By Olivier Tilloy

Do not rely on clicking to change the current section.

1682. By Olivier Tilloy

Ensure that the suggestions are hidden before considering the load complete, so that tests that expect to interact with the webview (by e.g. clicking in the middle of it) are more robust.

1681. By Olivier Tilloy

Make tests that interact with the "See More" button in the narrow new tab view more robust.

1680. By Olivier Tilloy

Make tests more robust.

1679. By Olivier Tilloy

Updated README.md to instruct how to run all the tests (unit+UI).

1678. By Olivier Tilloy

Merge the latest changes from staging.

1677. By Olivier Tilloy

Do not always wait for rendering of suggestions, if clicking them is not needed.

1676. By Olivier Tilloy

Declare that webbrowser-app breaks and replaces webbrowser-app-autopilot, to (hopefully) ensure it’s removed where it was previously installed.

1675. By Olivier Tilloy

Make suggestions tests more robust.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches