Merge lp://staging/~osomon/webbrowser-app/maxCacheSizeHint into lp://staging/webbrowser-app
Proposed by
Olivier Tilloy
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Olivier Tilloy | ||||
| Approved revision: | 936 | ||||
| Merged at revision: | 1019 | ||||
| Proposed branch: | lp://staging/~osomon/webbrowser-app/maxCacheSizeHint | ||||
| Merge into: | lp://staging/webbrowser-app | ||||
| Diff against target: |
110 lines (+35/-3) 3 files modified
debian/control (+1/-1) src/Ubuntu/Web/UbuntuWebContext.qml (+5/-2) src/Ubuntu/Web/plugin.cpp (+29/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~osomon/webbrowser-app/maxCacheSizeHint | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexandre Abreu (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Make use of the WebContext.
This bumps the dependency of qtdeclarative5-
To post a comment you must log in.
Revision history for this message
| Alexandre Abreu (abreu-alexandre) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Alexandre Abreu (abreu-alexandre) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I am wondering about the hardcoded value for webapp, it is pretty arbitrary and might benefit from being adjustable for certain webapps ... could you add a argument for this?
(added a nit comment inline)