webbrowser-app

Merge lp://staging/~osomon/webbrowser-app/listitems-now-handle-keyboard-activation into lp://staging/webbrowser-app

  1. listitems-now-handle-keyboard-activation
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 1474
Merged at revision: 1476
Proposed branch: lp://staging/~osomon/webbrowser-app/listitems-now-handle-keyboard-activation
Merge into: lp://staging/webbrowser-app
Diff against target: 117 lines (+0/-27)
7 files modified
src/app/webbrowser/BookmarksFoldersView.qml (+0/-2)
src/app/webbrowser/BookmarksFoldersViewWide.qml (+0/-1)
src/app/webbrowser/DownloadsPage.qml (+0/-7)
src/app/webbrowser/ExpandedHistoryView.qml (+0/-2)
src/app/webbrowser/HistoryView.qml (+0/-2)
src/app/webbrowser/HistoryViewWide.qml (+0/-11)
src/app/webbrowser/NewTabView.qml (+0/-2)
To merge this branch: bzr merge lp://staging/~osomon/webbrowser-app/listitems-now-handle-keyboard-activation
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+296527@code.staging.launchpad.net

Commit message

The UITK now handles Enter/Return/Space key presses to activate list items,
remove custom implementation.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1474
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/513/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/515/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/515
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/508
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial/508
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/503/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/503/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/503/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/503/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/503/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/503/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/513/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: