lp://staging/~osomon/webbrowser-app/historyUpdateOnLoadCommitted

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/webbrowser-app at revision 1372

Riccardo Padovani (community): Approve on 2016-03-01

PS Jenkins bot: Needs Fixing (continuous-integration) on 2016-03-01

Ubuntu Phablet Team: Pending requested 2015-05-18

Diff: 391 lines (+229/-40)

6 files modified

src/app/webbrowser/Browser.qml (+29/-2)
src/app/webbrowser/history-model.cpp (+37/-1)
src/app/webbrowser/history-model.h (+2/-1)
tests/autopilot/webbrowser_app/tests/http_server.py (+32/-1)
tests/autopilot/webbrowser_app/tests/test_history.py (+80/-34)
tests/unittests/history-model/tst_HistoryModelTests.cpp (+49/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1455858: History AWOL with YouTube "get more videos" button.	Medium	Invalid
Bug #1549780: [regression] favicons not stored in the history database	High	Fix Released

Link a bug report

Related blueprints

1029. By Olivier Tilloy on 2016-03-01

Move code out of else block to avoid compiler warning (control reaches end of non-void function [-Wreturn-type]).

1028. By Olivier Tilloy on 2016-03-01

Swap the order in which conditions are evaluated, from cheapest to most expensive.

1027. By Olivier Tilloy on 2016-02-29

Add an autopilot test to verify that history.pushState() inserts a new entry in the history database.

1026. By Olivier Tilloy on 2016-02-29

Add autopilot tests to verify that a page’s title is stored in history, but not dynamically updated.

1025. By Olivier Tilloy on 2016-02-29

Factor out common code.

1024. By Olivier Tilloy on 2016-02-29

Add some autopilot tests to verify that favicons are stored and updated in the history database.

1023. By Olivier Tilloy on 2016-02-26

Simplify code a bit.
Do not prevent dynamic favicon updates from updating the history database, to be consistent with what chromium does.

1022. By Olivier Tilloy on 2016-02-26

Add an update(…) method to HistoryModel, to allow updating the title and icon of an entry without incrementing the corresponding number of visits.

1021. By Olivier Tilloy on 2016-02-26

Merge the latest changes from trunk and resolve conflicts.

1020. By Olivier Tilloy on 2015-08-12

Merge the latest changes from trunk and resolve a conflict.