The Webapps-core project

Merge lp://staging/~osomon/webapps-core/gmaps-intent-hook into lp://staging/webapps-core

  1. gmaps-intent-hook
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Needs review
Proposed branch: lp://staging/~osomon/webapps-core/gmaps-intent-hook
Merge into: lp://staging/webapps-core
Diff against target: 37 lines (+9/-2)
3 files modified
webapp-googlemaps/manifest.json (+2/-1)
webapp-googlemaps/webapp-googlemaps.desktop (+1/-1)
webapp-googlemaps/webapp-googlemaps.url-dispatcher (+6/-0)
To merge this branch: bzr merge lp://staging/~osomon/webapps-core/gmaps-intent-hook
Reviewer Review Type Date Requested Status
David Barth (community) Approve
Review via email: mp+245982@code.staging.launchpad.net

Commit message

Add a URL dispatcher hook to the google maps app to handle intent:// URLs targetted at com.google.android.apps.maps.

Description of the change

WARNING: this shouldn’t be published until support for intent URIs in the container has landed in both vivid and RTM!

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) :
review: Approve
Reply
lp://staging/~osomon/webapps-core/gmaps-intent-hook updated
107. By Alexandre Abreu

Fix the gmaps URL pattern.

108. By Olivier Tilloy

Add an intent filter function.

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

You dont need the specific local-intent-filter.js file, when an intent uri is met, a default 'identity' filter is applied which basically is the same the one below,

Reply
lp://staging/~osomon/webapps-core/gmaps-intent-hook updated
109. By Olivier Tilloy

Remove the custom intent filter as it’s basically the identity function, which the container defaults to already.

Revision history for this message
Olivier Tilloy (osomon) wrote :

> You dont need the specific local-intent-filter.js file, when an intent uri is
> met, a default 'identity' filter is applied which basically is the same the
> one below,

D’oh… Removed, thanks.

Reply

Unmerged revisions

109. By Olivier Tilloy

Remove the custom intent filter as it’s basically the identity function, which the container defaults to already.

108. By Olivier Tilloy

Add an intent filter function.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: