Merge lp://staging/~osomon/unav/generate-json-translations into lp://staging/unav

Proposed by Olivier Tilloy
Status: Merged
Merged at revision: 109
Proposed branch: lp://staging/~osomon/unav/generate-json-translations
Merge into: lp://staging/unav
Diff against target: 81 lines (+26/-15)
4 files modified
.bzrignore (+1/-0)
Makefile (+21/-2)
nav/locales/3rdparty/README (+1/-0)
nav/locales/README (+3/-13)
To merge this branch: bzr merge lp://staging/~osomon/unav/generate-json-translations
Reviewer Review Type Date Requested Status
costales Approve
Review via email: mp+304611@code.staging.launchpad.net

Commit message

Generate JSON translations with the 'translations' rule.

To post a comment you must log in.
Revision history for this message
costales (costales) wrote :

So great :)

One question only please. Is OK the duplicates, like these?

costales@dev:~/Desktop/generate-json-translations$ find . -name messages-zh?TW.json
./nav/locales/po/messages-zh-TW.json
./nav/locales/po/messages-zh_TW.json
costales@dev:~/Desktop/generate-json-translations$

Thanks in advance!

review: Approve
Revision history for this message
Olivier Tilloy (osomon) wrote :

Yes, they are harmless. Only the version with dashes will be seen and loaded by jquery-localize.

When we add a rule to the Makefile to build a click/snap package, we can exclude all json files that have an "_" or a "@" in their names.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches