Merge lp://staging/~osomon/ubuntu/focal/apport/upgrade-urls-re into lp://staging/~ubuntu-core-dev/ubuntu/focal/apport/ubuntu

Proposed by Olivier Tilloy
Status: Merged
Merge reported by: Brian Murray
Merged at revision: not available
Proposed branch: lp://staging/~osomon/ubuntu/focal/apport/upgrade-urls-re
Merge into: lp://staging/~ubuntu-core-dev/ubuntu/focal/apport/ubuntu
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
gtk/apport-gtk (+1/-1)
To merge this branch: bzr merge lp://staging/~osomon/ubuntu/focal/apport/upgrade-urls-re
Reviewer Review Type Date Requested Status
Brian Murray Approve
Review via email: mp+382846@code.staging.launchpad.net

Description of the change

This is a quick fix for bug #1871185.

Matching all valid URLs with a regular expression is a complex problem, so I'm pretty sure this doesn't cover all cases, but at least it covers the case for "ubuntu-bug chromium" (scratching my own itch).

I wonder though, shouldn't that code be refactored to build a hyperlink from the URL before inserting it into the text (when setting the value of report['UnreportableReason'] in collect_info())? In that way there wouldn't be a need for using regular expressions to guess where a URL might be.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I merged this but somehow Launchpad didn't catch it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches