Merge lp://staging/~osomon/software-center/too_many_refreshes into lp://staging/software-center
Proposed by
Olivier Tilloy
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merge reported by: | Gary Lasker | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp://staging/~osomon/software-center/too_many_refreshes | ||||
| Merge into: | lp://staging/software-center | ||||
| Diff against target: |
38 lines (+16/-1) 1 file modified
softwarecenter/apt/aptcache.py (+16/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~osomon/software-center/too_many_refreshes | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| software-store-developers | code functional | Pending | |
|
Review via email:
|
|||
Description of the change
This branch fixes bug #563163.
The APT cache's monitoring mechanism wasn't considering whether the cache had already been re-opened explicitly, and it was scheduling several re-openings in a row.
This branch introduces a timestamp for the cache to remember when it was last re-opened and discard notifications within an arbitrary period of 10 seconds after the last re-opening.
It also makes sure only one re-opening is scheduled at any given time at most.
To post a comment you must log in.
Revision history for this message
| Gary Lasker (gary-lasker) wrote | # |
Revision history for this message
| Olivier Tilloy (osomon) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hello Olivier!
I am going through open pending reviews and with regard to this one it seems not this exact branch, but a variant of your fix was committed to fix the corresponding bug 563163. Based on that (and the fact that the bug is set fix committed) I'll set the status of this review to merged.
Thanks as always for your good work! I'm sure you know it's very much appreciated.
Best to you! I look forward to talking to you soon,
Gary