notes-app

Merge lp://staging/~osomon/notes-app/fix-pep8-warnings into lp://staging/notes-app

  1. fix-pep8-warnings
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 195
Merged at revision: 202
Proposed branch: lp://staging/~osomon/notes-app/fix-pep8-warnings
Merge into: lp://staging/notes-app
Diff against target: 119 lines (+20/-14)
5 files modified
tests/autopilot/notes_app/tests/test_delete.py (+2/-1)
tests/autopilot/notes_app/tests/test_expand_collapse.py (+12/-10)
tests/autopilot/notes_app/tests/test_images.py (+2/-1)
tests/autopilot/notes_app/tests/test_parts.py (+2/-1)
tests/autopilot/notes_app/tests/test_quit.py (+2/-1)
To merge this branch: bzr merge lp://staging/~osomon/notes-app/fix-pep8-warnings
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ugo Riboni (community) Approve
Review via email: mp+188523@code.staging.launchpad.net

Commit message

Fix pep8 warnings.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:195
http://jenkins.qa.ubuntu.com/job/notes-app-ci/154/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4264
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1936
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/49
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/52
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/52/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/49
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/555
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/133
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/133/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1939
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1939/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1631
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1649

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/154/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:195
http://jenkins.qa.ubuntu.com/job/notes-app-ci/155/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4270
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1947
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/50
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/53/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/50
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/560
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/138
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/138/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1949
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1949/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1640
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1658

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/155/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:195
http://jenkins.qa.ubuntu.com/job/notes-app-ci/156/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4278
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1961
    FAILURE: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/51/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/54
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/54/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/51
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/567
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/146
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/146/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1963
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1963/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1654
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1672

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/156/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:195
http://jenkins.qa.ubuntu.com/job/notes-app-ci/157/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4285
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1980
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/52
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/55
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/55/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/52
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/574
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/153
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/153/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1982
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1982/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1672
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1689

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/157/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

Code looks ok for me, so comment-approving until CI gets its stuff together.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:195
http://jenkins.qa.ubuntu.com/job/notes-app-ci/166/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4347
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2066
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/61
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/64
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/64/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/61
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/634
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/221
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/221/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2068
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2068/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1754
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1771

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/166/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:195
http://jenkins.qa.ubuntu.com/job/notes-app-ci/167/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4353
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2073
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/62
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/65
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/65/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/62
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/639
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/227
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/227/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2075
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2075/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1759
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1777

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/167/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:195
http://10.97.0.26:8080/job/notes-app-ci/184/
Executed test runs:
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-saucy/4682
    UNSTABLE: http://10.97.0.26:8080/job/generic-mediumtests-touch/2489
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-amd64-ci/79
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-armhf-ci/82
        deb: http://10.97.0.26:8080/job/notes-app-saucy-armhf-ci/82/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-i386-ci/79
    SUCCESS: http://10.97.0.26:8080/job/autopilot-testrunner-otto-saucy/868
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-amd64/557
        deb: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-amd64/557/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-armhf/2491
        deb: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-armhf/2491/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://10.97.0.26:8080/job/generic-mediumtests-runner-maguro/2047
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-runner-mako/2060

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/notes-app-ci/184/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:195
http://10.97.0.26:8080/job/notes-app-ci/185/
Executed test runs:
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-saucy/4683
    UNSTABLE: http://10.97.0.26:8080/job/generic-mediumtests-touch/2493
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-amd64-ci/80
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-armhf-ci/83
        deb: http://10.97.0.26:8080/job/notes-app-saucy-armhf-ci/83/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-i386-ci/80
    SUCCESS: http://10.97.0.26:8080/job/autopilot-testrunner-otto-saucy/869
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-amd64/558
        deb: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-amd64/558/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-armhf/2495
        deb: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-armhf/2495/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-runner-maguro/2051
    UNSTABLE: http://10.97.0.26:8080/job/generic-mediumtests-runner-mako/2064

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/notes-app-ci/185/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:195
http://10.97.0.26:8080/job/notes-app-ci/187/
Executed test runs:
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-saucy/4685
    UNSTABLE: http://10.97.0.26:8080/job/generic-mediumtests-touch/2495
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-amd64-ci/82
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-armhf-ci/85
        deb: http://10.97.0.26:8080/job/notes-app-saucy-armhf-ci/85/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-i386-ci/82
    SUCCESS: http://10.97.0.26:8080/job/autopilot-testrunner-otto-saucy/871
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-amd64/560
        deb: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-amd64/560/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-armhf/2497
        deb: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-armhf/2497/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-runner-maguro/2053
    UNSTABLE: http://10.97.0.26:8080/job/generic-mediumtests-runner-mako/2066

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/notes-app-ci/187/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:195
http://10.97.0.26:8080/job/notes-app-ci/189/
Executed test runs:
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-saucy/4688
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-touch/2498
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-amd64-ci/84
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-armhf-ci/87
        deb: http://10.97.0.26:8080/job/notes-app-saucy-armhf-ci/87/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/notes-app-saucy-i386-ci/84
    SUCCESS: http://10.97.0.26:8080/job/autopilot-testrunner-otto-saucy/874
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-amd64/563
        deb: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-amd64/563/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-armhf/2500
        deb: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-armhf/2500/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-runner-maguro/2055
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-runner-mako/2068

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/notes-app-ci/189/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches