Merge lp://staging/~osomon/moovida/fix_uri_quoting into lp://staging/moovida
Proposed by
Olivier Tilloy
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp://staging/~osomon/moovida/fix_uri_quoting |
Merge into: | lp://staging/moovida |
Diff against target: |
131 lines (+83/-8) 3 files modified
elisa-plugins/elisa/plugins/gstreamer/decodebin2_pipeline.py (+24/-2) elisa-plugins/elisa/plugins/gstreamer/old_pipeline.py (+24/-2) elisa-plugins/elisa/plugins/poblesec/player_video.py (+35/-4) |
To merge this branch: | bzr merge lp://staging/~osomon/moovida/fix_uri_quoting |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guillaume Emont | code functional | Approve | |
Review via email:
|
To post a comment you must log in.
This patch fixes the symptoms of bug #491874. bazaar. launchpad. net/~moovida- developers/ moovida/ relook/ revision/ 1599): only "file://" URLs are escaped. URLs for distant resources thus remain unchanged.
It is a refinement of Fernando's patch (see http://
As extensively explained in the comments I added to the code, this patch is by no means a proper fix to the underlying issue, which is that "file://" URIs are not correctly built in the first place. It is merely a quick fix, as unintrusive as possible.
The careful reviewer will make sure that the changes are relevant and that the comments make sense. He will also verify that bug #491874 is fixed in a variety of situations [1], and that indexing, thumbnailing and playback of local audio and video files containing reserved characters work fine. In particular, there shouldn't be regressions on bug #374305 and bug #296517. As noted by Fernando in the first patch, indexing and thumbnailing of pictures containing reserved characters should also work, but displaying them in the slideshow player will fail. This can be considered as a separate issue.
Thanks for all the shoes!
Olivier
[1] Tests can be done using the arte plugin using e.g. a French proxy or the grooveshark plugin. Note that for the latter, another issue prevents playback, but a patched egg is attached to bug #451125.