dialer-app

Merge lp://staging/~osomon/dialer-app/handle-slashless-urls into lp://staging/dialer-app

  1. handle-slashless-urls
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 305
Merged at revision: 306
Proposed branch: lp://staging/~osomon/dialer-app/handle-slashless-urls
Merge into: lp://staging/dialer-app
Diff against target: 29 lines (+7/-5)
1 file modified
src/dialerapplication.cpp (+7/-5)
To merge this branch: bzr merge lp://staging/~osomon/dialer-app/handle-slashless-urls
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+239597@code.staging.launchpad.net

Commit message

Also handle URLs of the form "tel:+1234567890", i.e. without slashes (those are common on web pages).

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

Note: url-dispatcher currently doesn’t accept this type of URLs, but it will be patched to do so.

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Code looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches