Ubuntu
systemd package

Merge ~os369510/ubuntu/+source/systemd:ubuntu-impish into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-impish

  1. Git
  2. lp:~os369510/ubuntu/+source/systemd
  3. ubuntu-impish
  4. Merge into ubuntu-impish
Proposed by jeremyszu
Status: Merged
Merge reported by: Lukas Märdian
Merged at revision: 4f2b260b95bb40c7b377f346c7a4f13d468a4e98
Proposed branch: ~os369510/ubuntu/+source/systemd:ubuntu-impish
Merge into: ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-impish
Diff against target: 79 lines (+65/-0)
2 files modified
debian/patches/lp1966179-add-more-hp-dmi-to-unblock-intel-hid-event.patch (+64/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Lukas Märdian Approve
Julian Andres Klode Abstain
Nick Rosbrook Pending
Dimitri John Ledkov Pending
Review via email: mp+418431@code.staging.launchpad.net

Commit message

Same story from lp1955997, some HP machines are using intel-hid instead
of HPQ6001. Thus, add them in the allowing list.
Specify the dmi string precisely to prevent introduce the regression.

Below launchpad tickets could be reference:
from 1966170:
pnHPProBook44014inchG9NotebookPC
pnHPProBook45015.6inchG9NotebookPC

from 1965898:
pnHPElitex36083013inchG92-in-1NotebookPC

from 1966014:
pnHPEliteBook104014inchG9NotebookPC
pnHPEliteBook84014inchG9NotebookPC
pnHPElitex360104014inchG92-in-1NotebookPC
pnHPEliteBook86016inchG9NotebookPC

from 1964913:
pnHPEliteBook64014inchG9NotebookPC
pnHPEliteBook65015.6inchG9NotebookPC

In the mail from HP (please see the lp1966179), HP also confirmed the
previous two platforms' dmi string need to adjust.
pnHPZBookFury16G9MobileWorkstationPC
pnHPZBookStudio16inchG9MobileWorkstationPC

To post a comment you must log in.
Revision history for this message
Julian Andres Klode (juliank) :
review: Abstain
Revision history for this message
Lukas Märdian (slyon) wrote :

LGTM overall. we're re-using the allow-list introduced in LP: #1955997 that only affects HP machines, so I consider this a low rist change.

I've combined your two top commits into a single one, mentioning the LP: #1966179 bug number, so it shows up correctly in the debian/changelog.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches