Merge lp://staging/~openerp-dev/openobject-client-web/6.0-opw-591397-xal into lp://staging/openobject-client-web

Proposed by Xavier ALT
Status: Needs review
Proposed branch: lp://staging/~openerp-dev/openobject-client-web/6.0-opw-591397-xal
Merge into: lp://staging/openobject-client-web
Diff against target: 121 lines (+25/-15)
4 files modified
addons/openerp/widgets/listgrid.py (+2/-2)
addons/openerp/widgets/listgroup.py (+13/-5)
addons/openerp/widgets/search.py (+9/-7)
addons/openerp/widgets/templates/listgrid/listgroup.mako (+1/-1)
To merge this branch: bzr merge lp://staging/~openerp-dev/openobject-client-web/6.0-opw-591397-xal
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+162727@code.staging.launchpad.net

Description of the change

Hi,

This fixes multiple things:

- List should not fetch any data in grouped mode - this is handled by Listgroup and MultipleGroup themself (using read_group).
  => This effectively fix some performance problem cause by reading all records (limit = -1 in grouped mode).

- When having 'search_default_FILTERNAME' in context, even when user uncheck this filter 'FILTERNAME' the list was still considering this filter groupby and domain.

- When having 'group_by_no_leaf' in context and no grouping criteria the list was showing 'row expand' which is wrong.

Regards,
Xavier

To post a comment you must log in.

Unmerged revisions

4915. By Xavier ALT

[FIX] list: prevent List from fetching unnecessary data in grouped mode - this is handled by Listgroup and MultipleGroup themselve

4914. By Xavier ALT

[FIX] list: when view has 'group_by_no_leaf' in context and no grouping key - the view was badly showing row expand

4913. By Xavier ALT

[FIX] search view: fix filter no considering user choice when filter is active by default (considering the context)

  - If filter is active by default (search_default_FILTERNAME) it's domain and
    context was wrongly added if user manually uncheck it (search_data = {FILTERNAME: 0}).

    We now consider filter domain + context depending on 'def_checked' value - which
    respect both default value and user choice.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.