Odoo Addons (MOVED TO GITHUB)

Reviewer	Date Requested	Status
DJ Patel (OpenERP) (community)		Needs Resubmitting on 2012-09-10
Mustufa Rangwala (Open ERP) (community)		Needs Fixing on 2012-08-24
Moisés López - http://www.vauxoo.com (community)		Approve on 2012-03-12
Raphael Collet (OpenERP) (community)		Needs Information on 2012-02-06
Purnendu Singh (OpenERP) (community)	2011-12-07	Needs Fixing on 2011-12-12
qdp (OpenERP)	2012-02-06	Pending
Review via email: mp+84734@code.staging.launchpad.net

Description of the change

Hello Sir,

I have fix the issue: https://bugs.launchpad.net/openobject-addons/+bug/896462 "[trunk & 6.0] [account] [wizard account.invoice.refund] Invoice refund wizard make error with other relational fields".

Thanks and Regards,

Divyesh Makwana(MDI)

Revision history for this message

Purnendu Singh (OpenERP) (purnendu-singh) wrote on 2011-12-12:

hello Divyesh,

Your patch will not work in case of multiple invoice lines because of this
9 - 'invoice_line': invoice_lines,
90 - 'tax_line': tax_lines,
91 + 'invoice_line': inv_list[0],
92 + 'tax_line': tax_list[0],

it will also crash when tax_list is a blank list e.g:[]

Thanks
Purnendu singh

review: Needs Fixing

Revision history for this message

DJ Patel (OpenERP) (mdi-openerp) wrote on 2011-12-12:

Hello Sir,

I have improved the code as per your suggestion.

Thanks and Regards,

Divyesh Makwana(MDI)

review: Needs Resubmitting

Revision history for this message

Raphael Collet (OpenERP) (rco-openerp) wrote on 2012-02-06:

Getting rid of _refund_cleanup_lines is a good, since it is badly defined.
However, small change added by account_anglo_saxon is completely removed.
Is this correct?

review: Needs Information

Revision history for this message

Moisés López - http://www.vauxoo.com (moylop260) wrote on 2012-03-12:

Tested done!

review: Approve

Revision history for this message

Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote on 2012-08-24:

I think Raphael Collect point is correct, once we remove the _refund_cleanup_lines from anglo_saxon module the functionality provided by that method will be completely hide.

Please check and fix it.

Thanks,
Mustufa (mra)

review: Needs Fixing

Revision history for this message

DJ Patel (OpenERP) (mdi-openerp) wrote on 2012-09-10:

Hello Sir,

I use copy_data() to duplicate and modify an existing record properly instead of the strange stuff done in refund().

So refund() should be based on a call to copy_data() on the invoice, and not manual steps like that.

I totally removed _refund_cleanup_lines() function from 'account' and 'account_anglo_saxon'.

In order to not hide the functionality provided by 'account_anglo_saxon' module i override the 'refund' method.

Thanks,
Divyesh

review: Needs Resubmitting

lp://staging/~openerp-dev/openobject-addons/trunk-bug-896462-mdi updated on 2012-09-10

5849. By DJ Patel (OpenERP) on 2012-09-10: [FIX] account, account_anglo_saxon : Improved the code.
5850. By DJ Patel (OpenERP) on 2012-09-10: [FIX] account : Improved the code.
5851. By DJ Patel (OpenERP) on 2012-09-10: [FIX] account : Improved the code.
5852. By DJ Patel (OpenERP) on 2012-09-10: [IMP] account_anglo_saxon : Improved the code.
5853. By DJ Patel (OpenERP) on 2012-09-10: [IMP] account_anglo_saxon : Improved the code.
5854. By DJ Patel (OpenERP) on 2012-09-10: [IMP] account_anglo_saxon : Improved the code.
5855. By DJ Patel (OpenERP) on 2012-09-10: [IMP] account : Improved the code.

Revision history for this message

DJ Patel (OpenERP) (mdi-openerp) wrote on 2012-09-10:

Now, we can totally get rid of _refund_cleanup_lines.

lp://staging/~openerp-dev/openobject-addons/trunk-bug-896462-mdi updated on 2012-10-11

5856. By DJ Patel (OpenERP) on 2012-09-11: [Merge] Merge with main addons.
5857. By DJ Patel (OpenERP) on 2012-09-11: [IMP] account : Override the 'copy_data' instead of 'copy' orm method.
5858. By DJ Patel (OpenERP) on 2012-09-11: [IMP] account_anglo_saxon : Improved the code.
5859. By DJ Patel (OpenERP) on 2012-09-11: [IMP] account_anglo_saxon : Improved the code.
5860. By DJ Patel (OpenERP) on 2012-09-11: [IMP] account_anglo_saxon : Improved the code.
5861. By DJ Patel (OpenERP) on 2012-09-12: [Merge] Merge with main addons.
5862. By DJ Patel (OpenERP) on 2012-09-14: [Merge] Merge with main addons.
5863. By DJ Patel (OpenERP) on 2012-09-17: [Merge] Merge with main addons.
5864. By DJ Patel (OpenERP) on 2012-09-17: [REM] account : Removed unused object references.
5865. By DJ Patel (OpenERP) on 2012-09-18: [Merge] Merge with main addons.
5866. By DJ Patel (OpenERP) on 2012-09-19: [Merge] Merge with main addons.
5867. By DJ Patel (OpenERP) on 2012-09-20: [Merge] Merge with main addons.
5868. By DJ Patel (OpenERP) on 2012-09-21: [Merge] Merge with main addons.
5869. By DJ Patel (OpenERP) on 2012-09-24: [Merge] Merge with main addons.
5870. By DJ Patel (OpenERP) on 2012-09-25: [Merge] Merge with main addons.
5871. By DJ Patel (OpenERP) on 2012-09-26: [Merge] Merge with main addons.
5872. By DJ Patel (OpenERP) on 2012-09-27: [Merge] Merge with main addons.
5873. By DJ Patel (OpenERP) on 2012-09-27: [Merge] Merge with main addons.
5874. By DJ Patel (OpenERP) on 2012-09-28: [Merge] Merge with main addons.
5875. By DJ Patel (OpenERP) on 2012-10-01: [Merge] Merge with main addons.
5876. By DJ Patel (OpenERP) on 2012-10-03: [Merge] Merge with main addons.
5877. By DJ Patel (OpenERP) on 2012-10-04: [Merge] Merge with main addons.
5878. By DJ Patel (OpenERP) on 2012-10-05: [Merge] Merge with main addons.
5879. By DJ Patel (OpenERP) on 2012-10-08: [Merge] Merge with main addons.
5880. By DJ Patel (OpenERP) on 2012-10-09: [Merge] Merge with main addons.
5881. By DJ Patel (OpenERP) on 2012-10-10: [Merge] Merge with main addons.
5882. By DJ Patel (OpenERP) on 2012-10-11: [Merge] Merge with main addons.