Merge lp://staging/~openerp-dev/openobject-addons/6.0-opw-572985-ado into lp://staging/openobject-addons/6.0

Proposed by Amit Dodiya (OpenERP)
Status: Rejected
Rejected by: Olivier Dony (Odoo)
Proposed branch: lp://staging/~openerp-dev/openobject-addons/6.0-opw-572985-ado
Merge into: lp://staging/openobject-addons/6.0
Diff against target: 827 lines (+69/-0)
69 files modified
account/i18n/ar.po (+1/-0)
account/i18n/bg.po (+1/-0)
account/i18n/br.po (+1/-0)
account/i18n/bs.po (+1/-0)
account/i18n/ca.po (+1/-0)
account/i18n/cs.po (+1/-0)
account/i18n/da.po (+1/-0)
account/i18n/de.po (+1/-0)
account/i18n/el.po (+1/-0)
account/i18n/en_GB.po (+1/-0)
account/i18n/en_US.po (+1/-0)
account/i18n/es.po (+1/-0)
account/i18n/es_AR.po (+1/-0)
account/i18n/es_CL.po (+1/-0)
account/i18n/es_CR.po (+1/-0)
account/i18n/es_EC.po (+1/-0)
account/i18n/es_PY.po (+1/-0)
account/i18n/es_VE.po (+1/-0)
account/i18n/et.po (+1/-0)
account/i18n/eu.po (+1/-0)
account/i18n/fa.po (+1/-0)
account/i18n/fa_AF.po (+1/-0)
account/i18n/fi.po (+1/-0)
account/i18n/fr.po (+1/-0)
account/i18n/fr_BE.po (+1/-0)
account/i18n/gl.po (+1/-0)
account/i18n/gu.po (+1/-0)
account/i18n/he.po (+1/-0)
account/i18n/hi.po (+1/-0)
account/i18n/hr.po (+1/-0)
account/i18n/hu.po (+1/-0)
account/i18n/id.po (+1/-0)
account/i18n/it.po (+1/-0)
account/i18n/kab.po (+1/-0)
account/i18n/kk.po (+1/-0)
account/i18n/ko.po (+1/-0)
account/i18n/lo.po (+1/-0)
account/i18n/lt.po (+1/-0)
account/i18n/lv.po (+1/-0)
account/i18n/mk.po (+1/-0)
account/i18n/mn.po (+1/-0)
account/i18n/nb.po (+1/-0)
account/i18n/nl.po (+1/-0)
account/i18n/nl_BE.po (+1/-0)
account/i18n/oc.po (+1/-0)
account/i18n/pl.po (+1/-0)
account/i18n/pt.po (+1/-0)
account/i18n/pt_BR.po (+1/-0)
account/i18n/ro.po (+1/-0)
account/i18n/ru.po (+1/-0)
account/i18n/si.po (+1/-0)
account/i18n/sk.po (+1/-0)
account/i18n/sl.po (+1/-0)
account/i18n/sq.po (+1/-0)
account/i18n/sr.po (+1/-0)
account/i18n/sr@latin.po (+1/-0)
account/i18n/sv.po (+1/-0)
account/i18n/ta.po (+1/-0)
account/i18n/te.po (+1/-0)
account/i18n/th.po (+1/-0)
account/i18n/tlh.po (+1/-0)
account/i18n/tr.po (+1/-0)
account/i18n/ug.po (+1/-0)
account/i18n/uk.po (+1/-0)
account/i18n/ur.po (+1/-0)
account/i18n/vi.po (+1/-0)
account/i18n/zh_CN.po (+1/-0)
account/i18n/zh_HK.po (+1/-0)
account/i18n/zh_TW.po (+1/-0)
To merge this branch: bzr merge lp://staging/~openerp-dev/openobject-addons/6.0-opw-572985-ado
Reviewer Review Type Date Requested Status
Olivier Dony (Odoo) Disapprove
Numérigraphe (community) Abstain
Jean-Christophe VASSORT Pending
Naresh(OpenERP) Pending
Review via email: mp+98364@code.staging.launchpad.net

Description of the change

Hello,

"[FIX] Translations of Refund in PO file for GUI in v6"

Steps:
1). Create db with French language.
2). Create invoice, validate it and click on refund wizard
The translation in Refund type selection field is not translated.

The value in selection field should be translated.

Regards,
Amit

To post a comment you must log in.
Revision history for this message
Numérigraphe (numerigraphe) wrote :

This patch fixes only one string that was given as an example in Bug #933496. A global fix is needed for all the missing strings.
Lionel.

review: Disapprove (needs global fix)
5150. By Amit Dodiya (OpenERP)

[FIX] Translations of Refund in PO not in GUI for v6

Revision history for this message
Numérigraphe (numerigraphe) :
review: Abstain
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Hello,

This patch is fixing a symptom, but we have no fix for the root cause, so you will only fix a tiny bit of the issue and miss the big picture. You will also not fix the problem permanently.

Please check comment #4 on the bug which explains the issue.

Thanks!

review: Disapprove

Unmerged revisions

5150. By Amit Dodiya (OpenERP)

[FIX] Translations of Refund in PO not in GUI for v6

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.