Merge lp://staging/~openerp-dev/openerp-web/7.0-opw-598927-msh into lp://staging/openerp-web/7.0
Proposed by
Mohammed Shekha(Open ERP)
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~openerp-dev/openerp-web/7.0-opw-598927-msh |
| Merge into: | lp://staging/openerp-web/7.0 |
| Diff against target: |
36 lines (+6/-0) 1 file modified
addons/web/static/src/js/view_list.js (+6/-0) |
| To merge this branch: | bzr merge lp://staging/~openerp-dev/openerp-web/7.0-opw-598927-msh |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Olivier Laurent (Acsone) (community) | test | Approve | |
| Fabien Meghazi (OpenERP) | Pending | ||
| Xavier (Open ERP) | Pending | ||
|
Review via email:
|
|||
Description of the change
Hello,
Improved the prop of header row checkbox to select all record, it should disabled when there is group by with no data expanded or with no_groupby_leaf.
Demo: Go to Reporting -> Any analysis view with groupby_no_leaf, it shows checkbox in header, checkbox should be disabled until and unless there are row data avaialble in the list, this small usability but makes user confuse, it should also be disabled when group is collapsed(whenthere is no groupby_no_leaf), until group `is expanded there are no records in list so it should not be enabled.
Thanks.
To post a comment you must log in.
Revision history for this message
| Olivier Laurent (Acsone) (olivier-laurent) wrote | # |
review:
Approve
(test)
Unmerged revisions
- 4035. By Mohammed Shekha(OpenERP)<email address hidden>
-
[FIX]Improved the prop of header checkbox to select all record, it should disabled when there is group by with no data expanded or with no_groupby_leaf.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This branch clarifies the described situation.
Many thanks to merge it into the target branch...