Merge lp://staging/~openerp-commiter/openobject-client/ach-6.0-opw-lp718040 into lp://staging/openobject-client/6.0

Proposed by Anup(SerpentCS)
Status: Needs review
Proposed branch: lp://staging/~openerp-commiter/openobject-client/ach-6.0-opw-lp718040
Merge into: lp://staging/openobject-client/6.0
Diff against target: 27 lines (+15/-2)
1 file modified
bin/tools/datetime_util.py (+15/-2)
To merge this branch: bzr merge lp://staging/~openerp-commiter/openobject-client/ach-6.0-opw-lp718040
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Needs Fixing
Jay Vora (Serpent Consulting Services) (community) Needs Fixing
Olivier Dony (Odoo) Pending
Review via email: mp+50906@code.staging.launchpad.net

Description of the change

Hello,

     Representation of Date in GTK client has been fixed by this. The representations like %b %B %a %A %c etc were not being displayed in proper way.

Thanks.

To post a comment you must log in.
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Anup,

Thanks for such a good fix,but there seems a problem with the length of characters which can be accomodated within date widget.

Thanks.

review: Needs Fixing
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello Anup,

It needs improvement. one case I found is when I manually try to enter date in the date field. I have my user language as 'de_DE' selected which has date format as %A %d %B %Y .

Traceback (most recent call last):
  File "/home/naresh/workspace/OpenERP2011/stable6.0/client/bin/widget/view/form_gtk/date_widget.py", line 117, in _focus_out
    self.date_get()
  File "/home/naresh/workspace/OpenERP2011/stable6.0/client/bin/widget/view/form_gtk/date_widget.py", line 141, in date_get
    if self.initial_value[a] == tc[a]:
IndexError: string index out of range

review: Needs Fixing
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Do we have any updates Anup?

Unmerged revisions

1813. By Anup(OpenERP) <email address hidden>

[FIX] date_utils : Representation of date in Format fixed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.