Unity 8

Merge lp://staging/~om26er/unity8/show_password_on_label_tap into lp://staging/unity8

show_password_on_label_tap
Merge into trunk

Proposed by Omer Akram on 2014-11-05

Status:

Merged

Approved by:

Michael Zanetti on 2014-11-17

Approved revision:

1402

Merged at revision:

1437

Proposed branch:

lp://staging/~om26er/unity8/show_password_on_label_tap

Merge into:

lp://staging/unity8

Diff against target:

15 lines (+5/-0)

1 file modified

qml/Notifications/NotificationMenuItemFactory.qml (+5/-0)

To merge this branch:

bzr merge lp://staging/~om26er/unity8/show_password_on_label_tap

Related bugs:

Bug #1333228: [sdk] Clicking on checkbox label should toggle the checkbox	Medium	Fix Released
Bug #1389832: tapping on 'Show password' does not show the password	Undecided	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Zanetti (community)		2014-11-05	Approve on 2014-11-17
PS Jenkins bot (community)	continuous-integration		Approve on 2014-11-13
Review via email: mp+240767@code.staging.launchpad.net

Commit message

show password when tapped on the 'Show password' label, not just the checkbox.

Description of the change

show password when tapped on the 'Show password' label, not just the checkbox.

lp://staging/~om26er/unity8/show_password_on_label_tap updated on 2014-11-05

1398. By Omer Akram on 2014-11-05: fix as Saviq suggested

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-05:

FAILED: Continuous integration, rev:1397
http://jenkins.qa.ubuntu.com/job/unity8-ci/4831/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6492/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1817/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1927/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1925/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7744/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4831/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~om26er/unity8/show_password_on_label_tap updated on 2014-11-05

1399. By Omer Akram on 2014-11-05: need to have a MouseArea to click at

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-05:

FAILED: Continuous integration, rev:1398
http://jenkins.qa.ubuntu.com/job/unity8-ci/4833/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6495/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1819/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1929/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1927/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7747/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4833/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-05:

FAILED: Continuous integration, rev:1399
http://jenkins.qa.ubuntu.com/job/unity8-ci/4834/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6497/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1820/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1930/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1928/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7749/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4834/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~om26er/unity8/show_password_on_label_tap updated on 2014-11-05

1400. By Omer Akram on 2014-11-05: merge trunk

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-05:

FAILED: Continuous integration, rev:1400
http://jenkins.qa.ubuntu.com/job/unity8-ci/4835/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6499/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1821/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1931/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1929/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7751/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4835/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2014-11-06:

Checklist please

review: Needs Fixing

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2014-11-06:

See this wiki page on how to propose branches to unity8: https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8

This looks like it could need a test. Can you add one please? I guess it should be fine to add it into tst_Notifications.qml

review: Needs Fixing

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2014-11-06:

Hm.. I just realized this is a snap decision notification with private-menu-hits which we don't really have a nice way to mock yet. I'm ok to go without tests here. Please add the checklist and we're good.

lp://staging/~om26er/unity8/show_password_on_label_tap updated on 2014-11-13

1401. By Omer Akram on 2014-11-13: merge trunk
1402. By Omer Akram on 2014-11-13: fix tags

Revision history for this message

Omer Akram (om26er) wrote on 2014-11-13:

Are there any related MPs required for this MP to build/function as expected? Please list.
No.

Did you perform an exploratory manual test run of your code change and any related
functionality?
Yes.

Did you make sure that your branch does not contain spurious tags?
Yes, ran Saviq's script.

If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
No change.

If you changed the UI, has there been a design review?
Not needed.

Revision history for this message

Omer Akram (om26er) wrote on 2014-11-13:

@Saviq, I ran your script over this branch.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-13:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4897/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-13:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4898/rebuild

review: Approve (continuous-integration)

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2014-11-14:

Branch has a lot of spurious tags.

review: Needs Fixing

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2014-11-17:

* Did you perform an exploratory manual test run of the code change and any related functionality?

yes

* Did CI run pass? If not, please explain why.

yes

* Did you make sure that the branch does not contain spurious tags?

yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Mohammad Rakibul Hasan

Omer Akram

Unity Team