notes-app

Merge lp://staging/~om26er/notes-app/skip into lp://staging/notes-app

  1. skip
  2. Merge into trunk
Proposed by Omer Akram
Status: Rejected
Rejected by: Olivier Tilloy
Proposed branch: lp://staging/~om26er/notes-app/skip
Merge into: lp://staging/notes-app
Diff against target: 21 lines (+3/-1)
1 file modified
tests/autopilot/notes_app/tests/test_parts.py (+3/-1)
To merge this branch: bzr merge lp://staging/~om26er/notes-app/skip
Reviewer Review Type Date Requested Status
Olivier Tilloy Disapprove
PS Jenkins bot continuous-integration Approve
Bill Filler Pending
Review via email: mp+187967@code.staging.launchpad.net

Commit message

Skip problematic tests on nexus 4.

Description of the change

Skip problematic tests on nexus 4. There is still on module test_images that cannot be skipped because the way those tests are written makes it really hard to disable them, python does not like that.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:186
http://jenkins.qa.ubuntu.com/job/notes-app-ci/149/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4092
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1719
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/47
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/47/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/399
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4202
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4202/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1721
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1721/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1438
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1450

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/149/rebuild

review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

This shouldn’t be needed, let’s fix the app itself.

review: Disapprove
Revision history for this message
Olivier Tilloy (osomon) wrote :

On top of this, I’ve observed the failed CI runs of a few MRs for this specific problem, and it seems to affect all tests randomly, not just the tests in the test_parts module. So we’d need to skip every single test for this "solution" to be effective, which would render the autopilot tests pointless. We need to find a real fix.

Unmerged revisions

186. By Omer Akram

skip problematic tests on nexus 4, spent more than 6hours on them. Couldn't fix. I reported a bug for the notes-app which I think is also related.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches