notes-app

Merge lp://staging/~om26er/notes-app/remove_autopilot_workaround into lp://staging/notes-app

  1. remove_autopilot_workaround
  2. Merge into trunk
Proposed by Omer Akram
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 161
Merged at revision: 165
Proposed branch: lp://staging/~om26er/notes-app/remove_autopilot_workaround
Merge into: lp://staging/notes-app
Diff against target: 209 lines (+102/-38)
5 files modified
KeyboardRectangle.qml (+81/-0)
NotesApp.qml (+1/-35)
tests/autopilot/notes_app/emulators/main_window.py (+3/-0)
tests/autopilot/notes_app/tests/__init__.py (+14/-0)
tests/autopilot/notes_app/tests/test_parts.py (+3/-3)
To merge this branch: bzr merge lp://staging/~om26er/notes-app/remove_autopilot_workaround
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+176788@code.staging.launchpad.net

Commit message

added the functionality to make sure the keyboard appears before changing focus to another field.

Description of the change

added the functionality to make sure the keyboard appears before changing focus to another field.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:158
http://jenkins.qa.ubuntu.com/job/notes-app-ci/126/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1511
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/21
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/21/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1515
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1515/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1277

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/126/rebuild

review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

199 + if model() != 'Desktop':

209 + if model() != 'Desktop':

Those are not needed, as the check on model() is done already in assert_osk_eventually_shown() and assert_osk_eventually_hidden().

review: Needs Fixing
lp://staging/~om26er/notes-app/remove_autopilot_workaround updated
159. By Omer Akram

fix per suggestions

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:159
http://jenkins.qa.ubuntu.com/job/notes-app-ci/127/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1540
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/22
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/22/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1544
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1544/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1305

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/127/rebuild

review: Approve (continuous-integration)
Revision history for this message
Omer Akram (om26er) wrote :

> 199 + if model() != 'Desktop':
>
> 209 + if model() != 'Desktop':
>
> Those are not needed, as the check on model() is done already in
> assert_osk_eventually_shown() and assert_osk_eventually_hidden().

fixed.

Revision history for this message
Olivier Tilloy (osomon) wrote :

There is a conflict when merging in the latest trunk. Please merge and resolve.

review: Needs Fixing
lp://staging/~om26er/notes-app/remove_autopilot_workaround updated
160. By Omer Akram

merge trunk, fix conflicts

Revision history for this message
Omer Akram (om26er) wrote :

> There is a conflict when merging in the latest trunk. Please merge and
> resolve.

Done. Thanks

Revision history for this message
Olivier Tilloy (osomon) wrote :

129 + KeyboardRectangle {
130 + id: osk
131 }

The id is not needed, as it’s not used anywhere, so it can be safely removed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:160
http://jenkins.qa.ubuntu.com/job/notes-app-ci/128/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1597
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/23/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1601
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1601/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1351

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/128/rebuild

review: Approve (continuous-integration)
lp://staging/~om26er/notes-app/remove_autopilot_workaround updated
161. By Omer Akram

remove id for KeyboardRectangle, we don't use it

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:161
http://jenkins.qa.ubuntu.com/job/notes-app-ci/129/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1608
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/24
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/24/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1612
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1612/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1360

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/129/rebuild

review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches