Merge lp://staging/~olivier-martin/lightdm-gtk-greeter/auth-error-message into lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

Proposed by Olivier Martin
Status: Merged
Merged at revision: 291
Proposed branch: lp://staging/~olivier-martin/lightdm-gtk-greeter/auth-error-message
Merge into: lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Diff against target: 104 lines (+25/-10)
1 file modified
src/lightdm-gtk-greeter.c (+25/-10)
To merge this branch: bzr merge lp://staging/~olivier-martin/lightdm-gtk-greeter/auth-error-message
Reviewer Review Type Date Requested Status
LightDM Gtk+ Greeter Development Team Pending
Review via email: mp+224916@code.staging.launchpad.net

Description of the change

process_prompts(): Do not assume password_entry should be visible

Some PAM modules might do not use password_entry for their authentification step.

To post a comment you must log in.
Revision history for this message
Olivier Martin (olivier-martin) wrote :

Sorry, I put the wrong merge message. It should have been:

authentication_complete_cb(): To not overwrite error message from PAM module

The error message "Failed to authenticate" was overwritten the PAM error message.
PAM error messages are expected to be more informative than Greeter messages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches