Merge lp://staging/~oif-team/grail/trunk.whatversion into lp://staging/grail
Proposed by
Henrik Rydberg
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~oif-team/grail/trunk.whatversion |
| Merge into: | lp://staging/grail |
| Diff against target: |
2062 lines (+500/-952) 28 files modified
INSTALL (+2/-9) Makefile.am (+1/-1) configure.ac (+6/-2) include/grail-touch.h (+0/-85) src/Makefile.am (+5/-4) src/gebuf.h (+2/-2) src/gestures-drag.c (+3/-3) src/gestures-pinch.c (+3/-3) src/gestures-rotate.c (+3/-3) src/gestures-tapping.c (+2/-2) src/grail-api.c (+184/-145) src/grail-event.c (+18/-18) src/grail-gestures.c (+19/-19) src/grail-gestures.h (+8/-8) src/grail-impl.h (+16/-3) src/grail-inserter.c (+13/-18) src/grail-inserter.h (+7/-10) src/grail-recognizer.c (+1/-2) src/grail-recognizer.h (+1/-2) src/grailbuf.h (+60/-0) src/touch-caps.c (+0/-117) src/touch-dev.c (+0/-264) test/Makefile.am (+0/-9) test/grail-gesture.c (+0/-126) test/grail-touch.c (+0/-97) tools/Makefile.am (+7/-0) tools/grail-gesture.c (+126/-0) utouch-grail.sym.in (+13/-0) |
| To merge this branch: | bzr merge lp://staging/~oif-team/grail/trunk.whatversion |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stephen M. Webb (community) | Approve | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2011-01-03.
Description of the change
Here is the first step in a series of transformations for grail. The major problem in this one is that the grail ABI is intact, but there are symbols in grail1 which never should have been exported: gin and gru. Also, the touch symbols were not really intended for public use. This patch series removes all gin/gru/touch symbols, and replaces the internal touch logic with utouch-frame. Removing symbols should normally warrant an ABI change. However, the grail usage in all our packages so far are intact. So what version to give this change?
To post a comment you must log in.
Revision history for this message
| Chase Douglas (chasedouglas) wrote | # |
Revision history for this message
| Henrik Rydberg (rydberg) wrote | # |
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
An ABI-breaking change becomes obvious fairly quickly if it affects a developer. If someone is using the undocumented API and their stuff breaks, they can use the readelf tool to determine the symbols are missing and we can point them at the changelogs. Leaving the library version unaltered can save a lot of grief with the downstream Ubuntu people.
This merge builds OK after pulling in the latest unpackaged mtdev, evemu, and frame libraries and runs alright with geistest and the grail-gesture tool on maverick, so I'd give it a pass.