Grail

Merge lp://staging/~oif-team/grail/trunk.v1.0.17 into lp://staging/grail

  1. trunk.v1.0.17
  2. Merge into trunk
Proposed by Henrik Rydberg
Status: Merged
Merged at revision: 102
Proposed branch: lp://staging/~oif-team/grail/trunk.v1.0.17
Merge into: lp://staging/grail
Diff against target: 116 lines (+58/-5)
3 files modified
configure.ac (+1/-1)
src/grail-api.c (+56/-4)
src/grail-impl.h (+1/-0)
To merge this branch: bzr merge lp://staging/~oif-team/grail/trunk.v1.0.17
Reviewer Review Type Date Requested Status
Chase Douglas (community) Approve
Review via email: mp+41067@code.staging.launchpad.net

Description of the change

Alright, last trim patch before starting the real work for natty. No SRU or anything.

To post a comment you must log in.
Revision history for this message
Henrik Rydberg (rydberg) wrote :

The patch is a month old, and looking through it, I see things might turn up a bit differently a couple of weeks from now... So, either way is fine.

Revision history for this message
Chase Douglas (chasedouglas) wrote :

I don't have any problems with this, but I also think this won't go into Maverick and Natty grail will not need to deal with pointer emulation. I'll approve it and leave the decision up to you.

review: Approve
Revision history for this message
Duncan McGreggor (oubiwann) wrote :

On Wed, Nov 17, 2010 at 9:37 AM, Henrik Rydberg <email address hidden> wrote:
> The patch is a month old

Wow, kinda uncool that you never got a response back on it :-( If you
run into this again, be sure to ping someone. Or ping me: I'll sick
someone on the review :-)

Revision history for this message
Henrik Rydberg (rydberg) wrote :

Thanks - I actually did get response back then, and we decided to leave it for later, and for natty only. That's where we are now. :-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: