Grail

Merge lp://staging/~oif-team/grail/cooperate-with-xi2.1 into lp://staging/grail

  1. cooperate-with-xi2.1
  2. Merge into trunk
Proposed by Chase Douglas
Status: Merged
Merged at revision: 108
Proposed branch: lp://staging/~oif-team/grail/cooperate-with-xi2.1
Merge into: lp://staging/grail
Diff against target: 356 lines (+110/-146)
4 files modified
src/grail-api.c (+101/-139)
src/grail-impl.h (+0/-7)
src/grail-recognizer.h (+8/-0)
tools/grail-gesture.c (+1/-0)
To merge this branch: bzr merge lp://staging/~oif-team/grail/cooperate-with-xi2.1
Reviewer Review Type Date Requested Status
Stephen M. Webb (community) Approve
Review via email: mp+48399@code.staging.launchpad.net

Description of the change

Before XI 2.1, we were fine just grabbing events and dropping them on the floor or emulating pointer motion. Now, we need to play nicely with X. This includes sending X the unadulterated event stream if there are no gestures found. This branch has two main commits: one to remove the old pointer emulation code, and one to add new code for sending events to X when appropriate.

I'll be pushing this to the xorg-unstable ppa soon.

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

The changes look sensible, but the magic timing constants are buried in the code. I think it would be beneficial to future maintainers if they were moved to the top of the source file (as defines or static consts) and comments added to each reiterating what is in the change log.

Other than that stylistic suggestion this is good to go.

review: Approve
Revision history for this message
Chase Douglas (chasedouglas) wrote :

I liked the stylistic simplicity of having the consts within the function they are used. Keeping things in scope. But I also agree that it's nice having constants defined at the top. I'll move them up there when I merge it tomorrow.

Thanks!

Revision history for this message
Chase Douglas (chasedouglas) wrote :

I found a few issues, added comments, and cleaned up the code just a little bit more before merging. Nothing logically has changed though.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: