Merge lp://staging/~oif-team/ginn/subscribe-necessary into lp://staging/ginn

Proposed by Chase Douglas
Status: Merged
Merged at revision: 89
Proposed branch: lp://staging/~oif-team/ginn/subscribe-necessary
Merge into: lp://staging/ginn
Diff against target: 158 lines (+131/-10)
1 file modified
src/ginn.c (+131/-10)
To merge this branch: bzr merge lp://staging/~oif-team/ginn/subscribe-necessary
Reviewer Review Type Date Requested Status
Chase Douglas (community) Needs Fixing
Josh Fee (community) Approve
Review via email: mp+71268@code.staging.launchpad.net

Description of the change

Patch from Josh Fee to subscribe only to gestures that are requested in the wishes file.

To post a comment you must log in.
Revision history for this message
Josh Fee (joshfee) :
review: Approve
Revision history for this message
Chase Douglas (chasedouglas) wrote :

First, thanks Josh for the patch! The major change here is good, there's just a small list of things that need to be cleaned up:

* The comment at the top is great! Please remove the "Edits made by joshfee Aug 7 2011" line. When we merge the branch back to the tree I'll make sure to list you as the author of the commit.

* Please use 4 spaces for indentation so it fits with the rest of the source code.

* There's a multi-line comment that uses "///" at the beginning of each line. I would prefer if it had the same multi-line comment format as your comment at the top. Also, use "//" instead of "///" for single line comments.

* Please put the "int finished = 0" declaration with the other variable declarations at the top of the scope before the comments.

* Use plain printf(...) instead of fprintf(stdout, ...)

* Normally we want people to use the macros for gesture subscription, like GESTURE_TYPE_DRAG_1. However, that would cause an explosion of switch statements in the code if we enforced that here. I am ok with letting this slide.

Again, great code! Thanks for submitting it!

review: Needs Fixing
Revision history for this message
Josh Fee (joshfee) wrote :

The fprintf(...) statement is only there for debugging. Should this be left alone, or should I remove/comment it?

90. By Josh Fee

Fixed comments and indentation to adhere to convention.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.