Merge lp://staging/~oif-team/geis/lp_661946 into lp://staging/geis
Proposed by
Stephen M. Webb
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~oif-team/geis/lp_661946 |
| Merge into: | lp://staging/geis |
| Diff against target: |
25 lines (+7/-0) 2 files modified
ChangeLog (+6/-0) configure.ac (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~oif-team/geis/lp_661946 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chase Douglas (community) | Needs Fixing | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2010-10-18.
Description of the change
Added a configury check for the XCB prototype generator library package xcb-proto version 1.6 or later (LP: #661946).
To post a comment you must log in.
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The bug report should be mentioned in the changelog as well (LP: 661946). This will help people understand why the change was made by just browsing the commit history. It will also automatically mark the bug as "Fix Committed".
I know it's nit picky, but I think we should get into the habit of doing these things. Once it's ingrained in our workflow, things will be smoother.
Code wise, I think the "AC_MSG_ERROR([XCB code generation libraries not found])" is superfluous. If the package isn't found, an error message will be printed by default and the configure script will bail. All that should be needed is "PKG_CHECK_