Merge lp://staging/geis/2.x into lp://staging/geis
Proposed by
Stephen M. Webb
| Status: | Merged |
|---|---|
| Merged at revision: | 88 |
| Proposed branch: | lp://staging/geis/2.x |
| Merge into: | lp://staging/geis |
| Diff against target: |
1260 lines (+990/-32) 26 files modified
.bzrignore (+4/-0) ChangeLog (+138/-0) Makefile.am (+1/-1) configure.ac (+21/-0) include/geis/geis.h (+86/-1) libutouch-geis-xcb/Makefile.am (+4/-9) libutouch-geis-xcb/libutouch-geis-xcb.ver (+0/-15) libutouch-geis/Makefile.am (+47/-0) libutouch-geis/geis.c (+104/-0) libutouch-geis/geis_error.c (+143/-0) libutouch-geis/geis_error.h (+42/-0) libutouch-geis/geis_private.h (+36/-0) libutouch-geis/libutouch-geis.ver (+24/-0) testsuite/Makefile.am (+24/-1) testsuite/geis1/Makefile.am (+1/-1) testsuite/geis1/check_geis_internals.c (+1/-1) testsuite/geis2/Makefile.am (+36/-0) testsuite/geis2/check_error_codes.c (+31/-0) testsuite/geis2/check_geis2_api.c (+32/-0) testsuite/geis2/check_geis_new.c (+32/-0) testsuite/geis2/check_general_types.c (+32/-0) testsuite/geis2/check_version_macro.c (+32/-0) testsuite/geistest/Makefile.am (+1/-3) testsuite/libutouch-geis/Makefile.am (+53/-0) testsuite/libutouch-geis/check_error_reporting.c (+39/-0) testsuite/libutouch-geis/check_geis2_internals.c (+26/-0) |
| To merge this branch: | bzr merge lp://staging/geis/2.x |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mohamed IKBEL Boulabiar (community) | Approve | ||
| Henrik Rydberg (community) | Approve | ||
| Chase Douglas (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This looks like a big delta (and maybe it is) but it's mostly a bunch of boilerplate unit test code for implementing the GEIS v2.0 spec, plus sections 3.1 (general) and parts of 3.2 (library initialization) of the proposed GEIS v2.0 C Binding specification <https:/
The test suite is run with "make check" (requires the "check" package to be installed). Other build dependencies can be gleaned from the Ubuntu packaging.
The libutouch-geis library will continue to maintain backwards API and ABI compatibility with GEIS v1.0 after this.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1. Would it make sense to define GEIS_VERSION_2_0 as a negative number until its released? I'm just wondering what it will look like if someone is depending on it. They'll have to check if it's value is less than some huge number (i.e. 20101122) if they want to be sure it's an official release.
2. I didn't see a #define for the global error stack. Something like "#define GEIS_GLOBAL_ERR NULL" might be helpful.
I didn't go through this with a fine tooth comb, but everything else looks good to me. I'm approving it as is, you can decide to make changes for the above comments as you see fit. They aren't show stoppers :).