Merge lp://staging/~ohe/pyopenssl/crl-comp into lp://staging/~exarkun/pyopenssl/trunk
Proposed by
Olivier Hervieu
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~ohe/pyopenssl/crl-comp |
| Merge into: | lp://staging/~exarkun/pyopenssl/trunk |
| Diff against target: |
86 lines (+36/-3) 2 files modified
OpenSSL/crypto/crl.c (+34/-3) OpenSSL/test/test_crypto.py (+2/-0) |
| To merge this branch: | bzr merge lp://staging/~ohe/pyopenssl/crl-comp |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jean-Paul Calderone | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Add new method to get the issuer of a CRL (very usefull to for OCSP request handling).
Test included.
To post a comment you must log in.
Unmerged revisions
- 140. By Olivier Hervieu
-
Add a new get_issuer method on CRL object. Returns the CRL's issuer as string.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi, thanks for your contribution. Looking at the man page for X509_NAME_oneline I see this warning:
The functions X509_NAME_oneline() and X509_NAME_print() are legacy functions which produce a non standard output
form, they don't handle multi character fields and have various quirks and inconsistencies. Their use is strongly
discouraged in new applications.
It sounds like instead X509_NAME_print_ex or X509_NAME_print should be used instead. You can find an example of how to use these BIO-based functions to get a char* in crypto_CRL_export.
Also, all new APIs should be documented in doc/api/.
Thanks again.