Merge lp://staging/~ogra/xdiagnose/py3port into lp://staging/xdiagnose

- for k, r in codes.items():
+ for k, r in list(codes.items()):

This is just 2to3 being conservative; you don't actually need the list() here, since the body of the loop doesn't modify codes.

+ dates = list(dates.keys())
  dates.sort()
  return dates

Simpler: "return sorted(dates)"

+ pkgs = list(dpkg_events.keys())
  pkgs.sort()
  for pkg in pkgs:

"for pkg in sorted(dpkg_events):"

+ print(device.name, device.regex, end=' ')
...

Doesn't this end up writing double spaces sometimes (e.g. in the "NOT SUPPORTED" case)? I'd have been inclined to use end=''.

The rest looks fine to me, although I'd have been inclined to add print_function and absolute_import imports from __future__ as applicable just in case there's a need to revert the #! to /usr/bin/python for some reason.

Changes look good. Once you've verified the test suite is still happy let me know and I'll merge this in.

with the latest changes this branch should now be mergeable, UI and testsuite work fine in a quantal VM here

When I attempt to debuild -sa -S this branch I get an error on python3-apport:

The following packages have unmet dependencies:
 pbuilder-satisfydepends-dummy : Depends: debhelper (>= 7.0.50~) but it is not going to be installed
                                 Depends: dh-translations but it is not going to be installed
                                 Depends: python3 (>= 3.2) but it is not going to be installed
                                 Depends: python3-all but it is not going to be installed
                                 Depends: intltool but it is not going to be installed
                                 Depends: apport but it is not going to be installed
                                 Depends: python3-apport but it is not installable
                                 Depends: python3-distutils-extra (>= 2.32-2) but it is not going to be installed
E: Unmet dependencies. Try 'apt-get -f install' with no packages (or specify a solution).

I think that python3-apport might be ok as a package dependency rather than a build dependency since it's just the apport hooks that require it during their execution. But after moving that, there's this error:

dh_auto_clean
Traceback (most recent call last):
  File "setup.py", line 20, in <module>
    import DistUtilsExtra.auto
ImportError: No module named DistUtilsExtra.auto

Which is a bit of a head-scratcher. Maybe dh_auto_clean is calling setup.py as python2 or something?

sorry, indeed the build-dep was wrong and i'm also not sure why i used python3 in the package name (python-apport is actually the py3 version already), fixed now ...

the build error does not happen for me over here, it is indeed strange

Excellent, thanks!

I sorted out the build issue I was seeing. It appears that the package build requires *both* python-distutils-extra and python3-distutils-extra. Not sure why, but unless both are included as build requirements, the package fails in the dh_auto_clean proc. I'm guessing that this is running clean for both python2 and python3, or something like that.

There's still a couple warnings I'm seeing:

   dh_python3 -O--buildsystem=python_distutils
W: dh_python3:181: Python 2.x location detected, please use dh_python2: debian/xdiagnose/usr/lib/python2.7
   dh_python2 -O--buildsystem=python_distutils
W: dh_python2:334: Python 3.x location detected, please use dh_python3: debian/xdiagnose/usr/lib/python3
   dh_usrlocal -O--buildsystem=python_distutils

However I think those are unrelated, and sound possibly innocuous so am going to ignore them for now. But if these sound meaningful to you, I'd love some tips on resolving them.

Are you sure python-apport is the right thing to depend on? It seems to explicitly depend on Python 2: http://packages.ubuntu.com/quantal/python-apport