Phablet Tools

Merge lp://staging/~ogra/phablet-tools/phablet-config-fix-serial-vs-password into lp://staging/phablet-tools

  1. phablet-config-fix-serial-vs-password
  2. Merge into trunk
Proposed by Oliver Grawert
Status: Merged
Approved by: Manuel de la Peña
Approved revision: no longer in the source branch.
Merged at revision: 301
Proposed branch: lp://staging/~ogra/phablet-tools/phablet-config-fix-serial-vs-password
Merge into: lp://staging/phablet-tools
Diff against target: 52 lines (+12/-3)
1 file modified
phablet-config (+12/-3)
To merge this branch: bzr merge lp://staging/~ogra/phablet-tools/phablet-config-fix-serial-vs-password
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
PS Jenkins bot continuous-integration Approve
Para Siva (community) Approve
Review via email: mp+233486@code.staging.launchpad.net

Commit message

move phablet-config password option to -r (--remotepassword) to avoid a clash with the --serial option, add proper error handling if no password is set when attempting a package operation (LP: #1365933)

Description of the change

move phablet-config password option to -r (--remotepassword) to avoid a clash with the --serial option, add proper error handling if no password is set when attempting a package operation

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:302
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/373/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/phablet-tools-utopic-amd64-ci/54/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/phablet-tools-utopic-armhf-ci/54/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/phablet-tools-utopic-i386-ci/54/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/373/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Para Siva (psivaa) wrote :

+1. making the image writeable works with this change.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:303
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/374/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-utopic-amd64-ci/55
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-utopic-armhf-ci/55
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-utopic-i386-ci/55

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/374/rebuild

review: Approve (continuous-integration)
Revision history for this message
Manuel de la Peña (mandel) :
review: Approve
lp://staging/~ogra/phablet-tools/phablet-config-fix-serial-vs-password updated
301. By Oliver Grawert

move phablet-config password option to -r (--remotepassword) to avoid a clash with the --serial option, add proper error handling if no password is set when attempting a package operation (LP: #1365933) Fixes: 1365933
Approved by: PS Jenkins bot, Parameswaran Sivatharman, Manuel de la Peña

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches