PC enablement tools

Merge ~oem-solutions-engineers/pc-enablement/+git/oem-gap-allow-list:PCSWE-1199 into ~oem-solutions-engineers/pc-enablement/+git/oem-gap-allow-list:master

  1. Git
  2. lp:~oem-solutions-engineers/pc-enablement/+git/oem-gap-allow-list
  3. PCSWE-1199
  4. Merge into master
Proposed by Yao Wei
Status: Merged
Approved by: jeremyszu
Approved revision: 50f4e55d578c57436dac0661a10dd500d4350e62
Merged at revision: c0235d5c6d0346240d371dc17a1e3e55b898d414
Proposed branch: ~oem-solutions-engineers/pc-enablement/+git/oem-gap-allow-list:PCSWE-1199
Merge into: ~oem-solutions-engineers/pc-enablement/+git/oem-gap-allow-list:master
Diff against target: 50 lines (+21/-1)
4 files modified
common (+0/-1)
fossa-common (+2/-0)
somerville/fossa-common (+16/-0)
testtools (+3/-0)
Reviewer Review Type Date Requested Status
jeremyszu Approve
Review via email: mp+448058@code.staging.launchpad.net

Commit message

greenlight dell-recovery and oem package dependencies

To post a comment you must log in.
Revision history for this message
jeremyszu (os369510) wrote :

this is similar to https://code.launchpad.net/~andch/pc-enablement/+git/oem-gap-allow-list/+merge/446757.
Please see my comment below

review: Needs Information
Revision history for this message
Yao Wei (medicalwei) wrote :

PRD: https://docs.google.com/spreadsheets/d/14LMuYRwPmPsJgbh_1Nqpu7XcAWrGCXSA8HBvKiQnEqI

Most of the dependencies are related to the need of burning recovery CD. Some of these are just decorative or not needed.

Revision history for this message
Yao Wei (medicalwei) :
Revision history for this message
jeremyszu (os369510) wrote :

I meant do we have the corresponding items from PRD to justify those required packages, if not, could you please work with 4$ and KC to draft a mail to confirm with Dell? and we can put it in PRD

Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

We may be able to remove python3-progressbar because it is only used in bto builds.

Revision history for this message
Yao Wei (medicalwei) wrote :

> We may be able to remove python3-progressbar because it is only used in bto
> builds.

It will break Depends unless we also update dell-recovery to make it optional.

Revision history for this message
jeremyszu (os369510) wrote :

this looks much better.
I don't want to fight the historical issue on focal.

Green light mesa-utils because it's there in focal for a whole.

xorriso and its related packages are needed for "recovery" and would like to ask them be moved to "main" but I think we are good on asking this on Jammy (because they are in main since Kinetic).

fine on dvd+rw-tools and wodim as well because they're needed for d-r.

tlps for somerville power-consupmtion.

+python3-plumbum # dependency of oem-config-hack
+python3-tqdm # dependency of python3-checkbox-ng

are also good for tools dependency.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches