Merge lp://staging/~objectboxpc/harmonyseq/code-fixes into lp://staging/harmonyseq
Proposed by
Philip Chung
| Status: | Rejected | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Rejected by: | Rafał Cieślak | ||||||||
| Proposed branch: | lp://staging/~objectboxpc/harmonyseq/code-fixes | ||||||||
| Merge into: | lp://staging/harmonyseq | ||||||||
| Diff against target: |
25 lines (+2/-2) 2 files modified
src/Files.cpp (+1/-1) src/MidiDriver.cpp (+1/-1) |
||||||||
| To merge this branch: | bzr merge lp://staging/~objectboxpc/harmonyseq/code-fixes | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Rafał Cieślak | Pending | ||
|
Review via email:
|
|||
Description of the change
I encountered two errors while compiling on current Debian Testing. These commits fix the errors.
To post a comment you must log in.
Revision history for this message
| Rafał Cieślak (rafalcieslak256) wrote | # |
Unmerged revisions
- 754. By Philip Chung
-
fix conversion from std::ifstream to bool
- 753. By Philip Chung
-
fix error in make_pair template substitution
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thank you for this patch! Turns out there were many more compilation errors that had to be resolved, so I've fixed them all and released as 0.16.1.