Merge lp://staging/~numerigraphe-team/ocb-addons/7.0-inventory-readonly-lines into lp://staging/ocb-addons

Proposed by Lionel Sausin - Initiatives/Numérigraphe
Status: Rejected
Rejected by: Holger Brunn (Therp)
Proposed branch: lp://staging/~numerigraphe-team/ocb-addons/7.0-inventory-readonly-lines
Merge into: lp://staging/ocb-addons
Diff against target: 96 lines (+28/-12)
1 file modified
stock/stock_view.xml (+28/-12)
To merge this branch: bzr merge lp://staging/~numerigraphe-team/ocb-addons/7.0-inventory-readonly-lines
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Disapprove
Review via email: mp+210207@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-03-10.

Description of the change

As usability improvement in inventories, we propose to make the fields "product", "location" and "serial nb" read-only as soon as an inventory line is recorded.
This keeps users from mistakenly keeping wrong products in stock.

Consider you filled the inventory with the wizard :
Product A: 15
Product B : 20
And physically you really have :
Product A: 15
Product C: 20
It's tempting to change just the product on the 2nd line but it's wrong: that would not remove product B from the stock.
You actually have to set the 2nd line to 0 and add a 3rd line to record the right data.

There is a proposal to merge this into the trunk too, but it's in standby until the new WMS code gets merged.

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote : Posted in a previous version of this proposal

Yes, please link a bug report.

For readability, you might want to consider using '!=' instead of '<>'

review: Needs Fixing (code review)
8592. By Numérigraphe

[REF] use != instead of XML entities to make the code readble

Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
8593. By Numérigraphe

[REF] use != instead of XML entities to make the code readble (continued)

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid.

(I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad)

review: Disapprove

Unmerged revisions

8593. By Numérigraphe

[REF] use != instead of XML entities to make the code readble (continued)

8592. By Numérigraphe

[REF] use != instead of XML entities to make the code readble

8591. By Loïc Bellier - Numérigraphe

[IMP] make fields readonly on recorded inventory lines, so users are not tempted to change location/product/lot instead of creating new lines

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.