Merge lp://staging/~numerigraphe-team/ocb-addons/7.0-inventory-fill-precision into lp://staging/ocb-addons
Proposed by
Lionel Sausin - Initiatives/Numérigraphe
| Status: | Merged |
|---|---|
| Approved by: | Holger Brunn (Therp) |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 10039 |
| Proposed branch: | lp://staging/~numerigraphe-team/ocb-addons/7.0-inventory-fill-precision |
| Merge into: | lp://staging/ocb-addons |
| Diff against target: |
15 lines (+5/-0) 1 file modified
stock/wizard/stock_fill_inventory.py (+5/-0) |
| To merge this branch: | bzr merge lp://staging/~numerigraphe-team/ocb-addons/7.0-inventory-fill-precision |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Holger Brunn (Therp) | code review | Approve | |
| Pedro Manuel Baeza | code review | Approve | |
| Sandy Carter (http://www.savoirfairelinux.com) | code review, pep8 | Approve | |
|
Review via email:
|
|||
Description of the change
when a Physical inventory is filled with the wizard, the quantity of products is computed by summing all the stock moves, but it's not rounded to the correct precision.
This can lead to tiny differences when validating the inventory, particularly when a large number of decimals are used.
To post a comment you must log in.
Revision history for this message
| Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote | # |
review:
Needs Fixing
Revision history for this message
| Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote | # |
Revision history for this message
| Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote | # |
review:
Approve
(code review, pep8)
Revision history for this message
| Pedro Manuel Baeza (pedro.baeza) wrote | # |
review:
Approve
(code review)
Revision history for this message
| Holger Brunn (Therp) (hbrunn) | # |
review:
Approve
(code review)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
l.8 This is minor and I will not block because of it, but it would be nicer to split this line in two so it doesn't run too long.
l.10 Watch your indentation, it is not pep8.