OpenERP Community Backports (Addons)

Merge lp://staging/~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test into lp://staging/ocb-addons

  1. 7.0-inventory-dummy-moves-test
  2. Merge into 7.0
Proposed by Lionel Sausin - Initiatives/Numérigraphe
Status: Rejected
Rejected by: Holger Brunn (Therp)
Proposed branch: lp://staging/~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test
Merge into: lp://staging/ocb-addons
Diff against target: 63 lines (+48/-0)
2 files modified
stock/__openerp__.py (+1/-0)
stock/test/stock_inventory_dummy_moves.yml (+47/-0)
To merge this branch: bzr merge lp://staging/~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Disapprove
Stefan Rijnhart (Opener) Needs Information
Loïc Bellier - Numérigraphe (community) code review Approve
Review via email: mp+215453@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Loïc Bellier - Numérigraphe (lb-b) :
review: Approve (code review)
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Looks good in general, but I'm slightly puzzled the exception handling. Is it know when it raises and when it doesn't? Doesn't the occurrence of the exception render the test meaningless? And does that not make the whole excercise moot?

review: Needs Information
Revision history for this message
Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote :

Stefan you're probably right, I'll look into this and let you know.

Revision history for this message
Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote :

Fixed, still green in runbot.

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid.

(I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad)

review: Disapprove

Unmerged revisions

10084. By Numérigraphe

[FIX] don't ignore exceptions in the test, that would render the test useless.

10083. By Numérigraphe

[MERGE] latest ocb branch

10082. By Numérigraphe

[MERGE] update test to demo dataset in v7

10081. By Numérigraphe

[MERGE] Add a test for bug 1228156: Wizard "Fill inventory" creates wrong lines for moves where source=destination

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.