Merge lp://staging/~nueces/lalita/support-private-channels into lp://staging/lalita
Proposed by
nueces
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~nueces/lalita/support-private-channels |
| Merge into: | lp://staging/lalita |
| Diff against target: |
62 lines (+35/-3) 2 files modified
lalita.cfg.sample (+28/-1) lalita/ircbot.py (+7/-2) |
| To merge this branch: | bzr merge lp://staging/~nueces/lalita/support-private-channels |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Facundo Batista | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
This branch provide support to joining private channels that are protected by password.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This looks nice! However, some details:
- point at the end of the docstring
- remove blank in the ".get (...)"
And what it mandates a need fixing here: You need to provide test cases for this new feature.
Thank you very much!!