UTAH

Merge lp://staging/~nuclearbob/utah/test-failures into lp://staging/utah

  1. test-failures
  2. Merge into dev
Proposed by Max Brustkern
Status: Rejected
Rejected by: Max Brustkern
Proposed branch: lp://staging/~nuclearbob/utah/test-failures
Merge into: lp://staging/utah
Diff against target: 818 lines (+183/-187)
16 files modified
debian/changelog (+3/-0)
examples/run_utah_tests.py (+14/-4)
tests/test_config.py (+2/-6)
tests/test_parser.py (+12/-0)
tests/test_rsyslog.py (+1/-2)
tests/test_run.py (+26/-37)
tests/test_vm.py (+5/-10)
utah/client/runner.py (+2/-6)
utah/client/tests/test_client.py (+3/-3)
utah/client/tests/test_common.py (+2/-10)
utah/client/tests/test_probe.py (+2/-0)
utah/experimental.py (+3/-3)
utah/getfile.py (+71/-0)
utah/iso.py (+9/-43)
utah/provisioning/provisioning.py (+19/-42)
utah/run.py (+9/-21)
To merge this branch: bzr merge lp://staging/~nuclearbob/utah/test-failures
Reviewer Review Type Date Requested Status
Andy Doan (community) Disapprove
Review via email: mp+170720@code.staging.launchpad.net

Description of the change

This branch fixes self-test failures in the current (0.13) version. With it, I am able to run all server self tests via "nosetests tests" and pass all of them except test_vm.py. When I run "nosetests/test_vm.py," it passes, so I think it's a problem with the test code rather than the actual vm code. The problem is trying to write logs to the branch directory.

I don't know if we care about getting this in before the release, since it doesn't update any actual code that goes into the packages, but here it is just in case.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Okay, that failure is actually test_parser.py's fault, since it's changing the logpath. I'm trying to fix that now.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Also, the following client tests seem to be breaking on probe-related things:
test_common.py fails 1
test_probe.py fails 2
test_vcs_bzr.py fails 1
test_vcs_dev.py fails 1
test_vcs_git.py fails 1

test_eventstat.py, however, just skips one test when eventstat isn't installed, so that one at least looks good.

lp://staging/~nuclearbob/utah/test-failures updated
970. By Max Brustkern

Removed test for a branch that hasn't been merged yet

971. By Max Brustkern

Fixed test_probe to skip eventstat tests if eventstat isn't installed

972. By Max Brustkern

Removed battery test from common. We have a battery test in probes, and this one fails if there's no battery on the tested machine, unlike the one in probes

Revision history for this message
Andy Doan (doanac) wrote :

This branch also includes your get_file changes. Not sure if you intended that or not?

I'm going to release 0.13.1 without it. but I expect a 0.13.2 on monday, so we can merge then if needed.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Whoops, I thought I got rid of those. I'll try a rebase.

On Sat, Jun 22, 2013 at 5:06 AM, Andy Doan <email address hidden>wrote:

> This branch also includes your get_file changes. Not sure if you intended
> that or not?
>
> I'm going to release 0.13.1 without it. but I expect a 0.13.2 on monday,
> so we can merge then if needed.
> --
> https://code.launchpad.net/~nuclearbob/utah/test-failures/+merge/170720
> You are the owner of lp:~nuclearbob/utah/test-failures.
>

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Hmm, rebase isn't doing it. I guess I can fix that test case and just try
to land this after file-handling looks good?

On Sat, Jun 22, 2013 at 8:37 AM, Max Brustkern
<email address hidden>wrote:

> Whoops, I thought I got rid of those. I'll try a rebase.
>
>
> On Sat, Jun 22, 2013 at 5:06 AM, Andy Doan <email address hidden>wrote:
>
>> This branch also includes your get_file changes. Not sure if you intended
>> that or not?
>>
>> I'm going to release 0.13.1 without it. but I expect a 0.13.2 on monday,
>> so we can merge then if needed.
>> --
>> https://code.launchpad.net/~nuclearbob/utah/test-failures/+merge/170720
>> You are the owner of lp:~nuclearbob/utah/test-failures.
>>
>
>

Revision history for this message
Andy Doan (doanac) wrote :

I was having some weirdness today, so I cherry-picked just the fixes from this and merged it:

 https://code.launchpad.net/~doanac/utah/max-test-fixes

So we should be able to reject this MP and then you can check your file handling stuff in its own MP.

review: Disapprove
Revision history for this message
Max Brustkern (nuclearbob) wrote :

All right, sounds good.

Unmerged revisions

972. By Max Brustkern

Removed battery test from common. We have a battery test in probes, and this one fails if there's no battery on the tested machine, unlike the one in probes

971. By Max Brustkern

Fixed test_probe to skip eventstat tests if eventstat isn't installed

970. By Max Brustkern

Removed test for a branch that hasn't been merged yet

969. By Max Brustkern

Fixed static analysis issues

968. By Max Brustkern

Rolling back test_vm changes that didn't help

967. By Max Brustkern

Fixed test_rsyslog

966. By Max Brustkern

Created temp file to allow test_parser to run on a system without utah installed

965. By Max Brustkern

Fixed test_config

964. By Max Brustkern

Fixed test_vm

963. By Max Brustkern

Changed to decorator

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches