Autopilot

Merge lp://staging/~nuclearbob/autopilot/reorg into lp://staging/autopilot

  1. reorg
  2. Merge into trunk
Proposed by Max Brustkern
Status: Rejected
Rejected by: Max Brustkern
Proposed branch: lp://staging/~nuclearbob/autopilot/reorg
Merge into: lp://staging/autopilot
Diff against target: 1457 lines (+325/-309)
35 files modified
autopilot/__init__.py (+7/-210)
autopilot/_timeout.py (+2/-0)
autopilot/application/_launcher.py (+10/-10)
autopilot/clipboard.py (+2/-0)
autopilot/content.py (+4/-2)
autopilot/dbus_handler.py (+1/-0)
autopilot/display/_X11.py (+0/-4)
autopilot/display/__init__.py (+8/-0)
autopilot/display/_upa.py (+0/-5)
autopilot/exceptions.py (+2/-0)
autopilot/gestures.py (+2/-0)
autopilot/input/_X11.py (+17/-17)
autopilot/input/__init__.py (+9/-2)
autopilot/input/_common.py (+4/-4)
autopilot/input/_osk.py (+3/-3)
autopilot/input/_uinput.py (+10/-10)
autopilot/introspection/__init__.py (+18/-3)
autopilot/introspection/dbus.py (+5/-5)
autopilot/introspection/qt.py (+0/-5)
autopilot/introspection/types.py (+2/-2)
autopilot/keybindings.py (+6/-4)
autopilot/logging.py (+2/-0)
autopilot/matchers/__init__.py (+3/-0)
autopilot/platform.py (+2/-0)
autopilot/process/__init__.py (+6/-0)
autopilot/process/_bamf.py (+4/-4)
autopilot/run.py (+148/-6)
autopilot/testcase.py (+10/-8)
autopilot/testresult.py (+6/-0)
autopilot/utilities.py (+17/-0)
autopilot/vis/__init__.py (+2/-0)
autopilot/vis/bus_enumerator.py (+2/-0)
autopilot/vis/dbus_search.py (+5/-3)
autopilot/vis/main_window.py (+4/-2)
autopilot/vis/resources.py (+2/-0)
To merge this branch: bzr merge lp://staging/~nuclearbob/autopilot/reorg
Reviewer Review Type Date Requested Status
Max Brustkern (community) Disapprove
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+211392@code.staging.launchpad.net

Commit message

Reorganize the autopilot package

Description of the change

This is the beginning of some autopilot package reorganization. I'm just creating the MP now for easy shared diff viewing.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

I'd like to get comments on the current state of this and then proceed with what's working from it before making more substantial changes.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:463
http://jenkins.qa.ubuntu.com/job/autopilot-ci/581/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-amd64-ci/307/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-armhf-ci/307/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-i386-ci/216/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-autopilot/33/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4028/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/581/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~nuclearbob/autopilot/reorg updated
464. By Max Brustkern

Added more __all__ lists

Revision history for this message
Max Brustkern (nuclearbob) wrote :

At this point, most .py files outside of tests should have __all__. I didn't include:
    Many of the files starting with _ (presumably we don't want those definitions used externally)
    emulators.py (this has been deprecated for a while and maybe is a good first step for removal?)
    globals.py (I wanted to get more information before messing with this)
    Many files under introspection (I think much of that will be privatized)
    run.py (I think most of that will be privatized)

I'd like to get feedback on this and then figure out if we want to just try this in the next release or actually try making something private as well.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:464
http://jenkins.qa.ubuntu.com/job/autopilot-ci/587/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-amd64-ci/313/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-armhf-ci/313/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-i386-ci/222/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-autopilot/39/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4067/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/587/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Superseded by https://code.launchpad.net/~nuclearbob/autopilot/clean-init/+merge/211809

review: Disapprove

Unmerged revisions

464. By Max Brustkern

Added more __all__ lists

463. By Max Brustkern

Added __all__ to vis submodules

462. By Max Brustkern

Added __all__ to easy submodules

461. By Max Brustkern

Privatized parse_arguments

460. By Max Brustkern

Moved functions from __init__ into _info

459. By Max Brustkern

Cleaned up loggers

458. By Max Brustkern

Removed entry from __all__

457. By Max Brustkern

Moved argument parser into run

456. By Max Brustkern

Fixed flake8 issues

455. By Max Brustkern

Privatized loggers

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches