Merge lp://staging/~ntoll/ubiq/content-provider into lp://staging/ubiq
| Status: | Merged |
|---|---|
| Merged at revision: | 6 |
| Proposed branch: | lp://staging/~ntoll/ubiq/content-provider |
| Merge into: | lp://staging/ubiq |
| Diff against target: |
1287 lines (+1011/-78) 7 files modified
.bzrignore (+1/-0) ubiq/src/com/fluidinfo/ubiq/FluidDBProvider.java (+272/-27) ubiq/src/com/fluidinfo/ubiq/FluidDBProviderMetaData.java (+2/-1) ubiqtest/build.properties (+1/-1) ubiqtest/default.properties (+1/-1) ubiqtest/gen/com/fluidinfo/ubiq/test/R.java (+0/-23) ubiqtest/src/com/fluidinfo/ubiq/test/FluidDBProviderTest.java (+734/-25) |
| To merge this branch: | bzr merge lp://staging/~ntoll/ubiq/content-provider |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| ubiq-dev | Pending | ||
| ubiq-dev | big java | Pending | |
|
Review via email:
|
|||
Description of the change
This is a *big* block of functionality to add to the content provider.
The content-provider currently handles local storage of namespace, tag and tag-value information. For more information about what exactly a content-provider is try reading here: http://
What I'm looking for in this review:
1) Do the tests pass?
2) Do the tests make sense (each test starts with an intention - the code inside each test is commented to explain the specific case/code being exercised)?
3) Enough coverage..?
4) Does the code in the content provider make sense? (I'm basically following the guidelines Google set out in their docs and in the book "Pro Android 2").
5) Any other good ideas, comments, criticisms and so on!
The content-provider is incomplete!
ToDo:
* Add user and permission handling to make it feature complete (which I'll start immediately)
* Plug in the remote RESTful calls to FluidDB itself
Then the related blueprint will be fulfilled (see here: https:/
| Nicholas Tollervey (ntoll) wrote | # |
| Nicholas Tollervey (ntoll) wrote | # |
Apologies for the length of the diff. In future I'll do a merge for Users, Permissions and REST calls *each* rather than together. Also, Java code is nowhere near as compact as Python - but you knew that already ;-)