Ubuntu Terminal App

Merge lp://staging/~nskaggs/ubuntu-terminal-app/ap-restruct into lp://staging/ubuntu-terminal-app

ap-restruct
Merge into trunk

Proposed by Nicholas Skaggs on 2014-08-29

Status:

Merged

Approved by:

Nicholas Skaggs on 2014-09-03

Approved revision:

137

Merged at revision:

133

Proposed branch:

lp://staging/~nskaggs/ubuntu-terminal-app/ap-restruct

Merge into:

lp://staging/ubuntu-terminal-app

Diff against target:

763 lines (+299/-348)

5 files modified

src/app/qml/Terminal.qml (+0/-62)
tests/autopilot/ubuntu_terminal_app/__init__.py (+173/-7)
tests/autopilot/ubuntu_terminal_app/emulators.py (+0/-81)
tests/autopilot/ubuntu_terminal_app/tests/__init__.py (+35/-104)
tests/autopilot/ubuntu_terminal_app/tests/test_terminal.py (+91/-94)

To merge this branch:

bzr merge lp://staging/~nskaggs/ubuntu-terminal-app/ap-restruct

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2014-09-03
Ubuntu Terminal Developers		2014-08-29	Pending
Review via email: mp+232748@code.staging.launchpad.net

Commit message

Restructure test launching, fix 1341681

Description of the change

Restructure test launching, fix 1341681

remove hud actions

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-29:

FAILED: Continuous integration, rev:129
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/85/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1744/console
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1744/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/29

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/85/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-29:

FAILED: Continuous integration, rev:131
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/86/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1745/console
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1745/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/30

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/86/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~nskaggs/ubuntu-terminal-app/ap-restruct updated on 2014-08-29

132. By Nicholas Skaggs on 2014-08-29: animation fixes, split tests
133. By Nicholas Skaggs on 2014-08-29: flake8 happiness
134. By Nicholas Skaggs on 2014-08-29: tweak test_header
135. By Nicholas Skaggs on 2014-08-29: flake8

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-29:

FAILED: Continuous integration, rev:132
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/87/
Executed test runs:
FAILURE: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/31/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/87/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-29:

FAILED: Continuous integration, rev:135
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/88/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1748/console
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1748/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/32

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/88/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~nskaggs/ubuntu-terminal-app/ap-restruct updated on 2014-08-29

136. By Nicholas Skaggs on 2014-08-29: move circle menu helper

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-29:

FAILED: Continuous integration, rev:136
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/89/
Executed test runs:
FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1750/console
FAILURE: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/33/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/89/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alan Pope 🍺🐧🐱 🦄 (popey) wrote on 2014-09-01:

Looks like pyflakes issues:-

+ pyflakes .
./tests/autopilot/ubuntu_terminal_app/__init__.py:65: local variable 'kterm' is assigned to but never used
./debian/tmp/usr/lib/python3/dist-packages/ubuntu_terminal_app/__init__.py:65: local variable 'kterm' is assigned to but never used
./debian/ubuntu-terminal-app-autopilot/usr/lib/python3/dist-packages/ubuntu_terminal_app/__init__.py:65: local variable 'kterm' is assigned to but never used