Merge lp://staging/~nskaggs/ubuntu-calculator-app/drop-fixtures into lp://staging/~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 340
Merged at revision: 333
Proposed branch: lp://staging/~nskaggs/ubuntu-calculator-app/drop-fixtures
Merge into: lp://staging/~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target: 200 lines (+91/-61)
2 files modified
README.autopilot (+61/-0)
tests/autopilot/ubuntu_calculator_app/tests/__init__.py (+30/-61)
To merge this branch: bzr merge lp://staging/~nskaggs/ubuntu-calculator-app/drop-fixtures
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Riccardo Padovani Approve
Review via email: mp+237848@code.staging.launchpad.net

Commit message

This drops support for patching home via fixtures; instead the current user's home directory is assumed properly setup

Description of the change

This drops support for patching home via fixtures, and instead waits for a better fix from https://bugs.launchpad.net/ubuntu-app-launch/+bug/1376423.

If you run these tests without a test runner to setup the environment, these tests will modify the current user's home folder.

To post a comment you must log in.
337. By Nicholas Skaggs

add autopilot readme

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Confirming no apparmor errors present on RTM, image 92, using only these changes.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
338. By Nicholas Skaggs

switch to mocking on desktop only

339. By Nicholas Skaggs

update readme

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Didn't test on a device, but sounds reasonable. Anyway, there is a little type (see inline comment)

review: Needs Fixing
340. By Nicholas Skaggs

fix typo

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

lgtm

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches